From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Recent commit modifying mark-whole-buffer (master/aeb613ea95b7970e66d663ec5cba54e9ec0528fa) Date: Sat, 30 Apr 2016 16:34:15 +0200 Message-ID: <87oa8rp3mg.fsf@gnus.org> References: <87lh3x4dkb.fsf@gnus.org> <83wpngx69z.fsf@gnu.org>> <87fuu4bo3y.fsf@gnus.org> <83inz0wprx.fsf@gnu.org>> <87shy4a8d4.fsf@gnus.org> <83fuu4wnmm.fsf@gnu.org>> <87y47w5w0p.fsf@gnus.org>> <83bn4swdif.fsf@gnu.org>> <0943fde5-ec4e-40f5-85da-6cfe258f0513@default> <83y47wuqvg.fsf@gnu.org> <87eg9ouq24.fsf@gnus.org> <83shy4ups9.fsf@gnu.org> <87lh3wp390.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462026921 1753 80.91.229.3 (30 Apr 2016 14:35:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Apr 2016 14:35:21 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 30 16:35:12 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awVzE-0002pf-7L for ged-emacs-devel@m.gmane.org; Sat, 30 Apr 2016 16:35:12 +0200 Original-Received: from localhost ([::1]:58629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awVz7-0002Vg-2W for ged-emacs-devel@m.gmane.org; Sat, 30 Apr 2016 10:35:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awVyh-0001kk-3w for emacs-devel@gnu.org; Sat, 30 Apr 2016 10:34:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awVyV-0007CJ-By for emacs-devel@gnu.org; Sat, 30 Apr 2016 10:34:33 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:44564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awVyV-00078I-5i for emacs-devel@gnu.org; Sat, 30 Apr 2016 10:34:27 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awVyJ-0003Fn-OS; Sat, 30 Apr 2016 16:34:17 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 30 Apr 2016 10:19:15 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203456 Archived-At: Stefan Monnier writes: >> Yup. Like I said in the bug report, I think the solution here is to >> have read-from-minibuffer not apply the default face if there are any >> faces specified on the prompt string. > > "Not apply" sounds wrong. Better do an "append" so the face properties > provided to read-from-minibuffer get merged with the > minibuffer-prompt face. That was my original idea, but I think Drew is right that if somebody has said (read-from-minibuffer (propertize "foo" 'face 'bold)) it's pretty unlikely that they want `bold' merged with the blue face... I mean, they can also bind `minibuffer-prompt-properties', but that's... not very convenient, since it has other, necessary properties, or redefine the minibuffer-prompt face, but that's also not what you want to do for a single prompt. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no