From: npostavs@users.sourceforge.net
To: Drew Adams <drew.adams@oracle.com>
Cc: 24353@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#24353: 25.1.1: looking-back wrong info
Date: Fri, 02 Sep 2016 20:14:36 -0400 [thread overview]
Message-ID: <87oa45on4j.fsf@users.sourceforge.net> (raw)
In-Reply-To: <bb5f8437-5df1-4133-ac06-a5546f69d0f3@default> (Drew Adams's message of "Fri, 2 Sep 2016 16:59:30 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
>
> The right way to _encourage_ programmers to use it is to
> tell them precisely that: "Using LIMIT is recommended - it
> typically results in faster code."
>
> Or "strongly recommended". Or "You're nuts if you omit LIMIT!"
> Or whatever other positive or negative encouragement you think
> might be most effective and appropriate.
>
> Telling them nothing about this and, instead, just showing a
> false signature, does NOT help them.
So something like this:
diff --git i/lisp/subr.el w/lisp/subr.el
index e9e19d3..4d1267a 100644
--- i/lisp/subr.el
+++ w/lisp/subr.el
@@ -3533,7 +3533,10 @@ looking-back
LIMIT.
As a general recommendation, try to avoid using `looking-back'
-wherever possible, since it is slow."
+wherever possible, since it is slow.
+
+For backwards compatibility LIMIT may be omitted, but this usage
+is deprecated."
(declare
(advertised-calling-convention (regexp limit &optional greedy) "25.1"))
(let ((start (point))
>> > It should be a no-no to just change the advertized
>> > signature of a function, without changing the actual
>> > signature (code) and without otherwise changing the doc.
>>
>> You have some point there, but mentioning the last argument in the
>> docstring would be rather awkward, considering it's absent in the
>> advertised signature.
The number (and names) of arguments have not been changed.
>
> 2. We removed this sentence, which was the only suggestion
> related to performance:
>
> "As a general recommendation, try to avoid using
> `looking-back' wherever possible, since it is slow."
Not sure which version you're looking at, but that sentence is still
present on both emacs-25 and master branches.
next prev parent reply other threads:[~2016-09-03 0:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 8:48 bug#24353: 25.1.1: looking-back wrong info Andreas Röhler
2016-09-02 8:58 ` Eli Zaretskii
2016-09-02 9:57 ` Andreas Röhler
2016-09-02 10:04 ` Eli Zaretskii
2016-09-02 17:51 ` Drew Adams
2016-09-02 19:03 ` Eli Zaretskii
2016-09-02 20:10 ` Dmitry Gutov
2016-09-02 23:59 ` Drew Adams
2016-09-03 0:03 ` Dmitry Gutov
2016-09-03 0:10 ` Drew Adams
2016-09-03 0:14 ` npostavs [this message]
2016-09-03 0:15 ` Dmitry Gutov
2016-09-03 0:28 ` Drew Adams
2016-09-03 17:35 ` Clément Pit--Claudel
2016-09-03 18:10 ` Drew Adams
2016-09-03 18:24 ` Clément Pit--Claudel
2016-09-03 18:31 ` npostavs
2016-09-03 18:57 ` Drew Adams
2016-09-04 13:08 ` Michael Heerdegen
2016-09-03 17:50 ` Clément Pit--Claudel
2016-09-03 18:42 ` Drew Adams
2016-09-03 18:52 ` Eli Zaretskii
[not found] <<e554564c-50a0-8c71-3b79-183ffd54b9c3@easy-emacs.de>
[not found] ` <<83lgzael08.fsf@gnu.org>
[not found] ` <<a404cb34-311e-3fb3-dde8-4340e57c97e5@easy-emacs.de>
[not found] ` <<83k2euehyc.fsf@gnu.org>
[not found] ` <<bf60cf1c-b9b9-4505-ab9f-d518dcf1725c@default>
[not found] ` <<83eg52dszc.fsf@gnu.org>
2016-09-02 20:03 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa45on4j.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=24353@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.