From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: Feedback on changes to org-id Date: Thu, 22 Sep 2016 09:16:47 +0200 Message-ID: <87oa3gs8tc.fsf@gmx.us> References: <87fuphzv70.fsf@gmail.com> <87oa45z8y2.fsf@saiph.selenimh> <8760porioo.fsf@gmail.com> <87d1jwejh2.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmyG3-0005WX-7i for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 03:17:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmyFz-0004YE-Kv for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 03:17:23 -0400 Received: from [195.159.176.226] (port=39787 helo=blaine.gmane.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmyFz-0004XD-Ee for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 03:17:19 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1bmyFo-0000VC-30 for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 09:17:08 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Adam Porter writes: > Aaron Ecay writes: > >> The API has the following two functions already: >> - org-id-find-file-for: id -> file-name >> - org-id-find-id-in-file: id file -> position >> >> Imagine I add to this API org-id-find-marker: id -> marker. Then I >> think we can deprecate (and eventually delete) org-id-find, since all its >> uses can be replaced by some combination of the other 3 functions. (We >> could also keep it as a convenience function wrapping the other 3, but >> it hardly seems worth it: the marker case just adds the overhead of >> another funcall, whereas a significant proportion of the non-marker >> calls in the codebase actually only care about the file name, so it is a >> waste of effort to calculate the buffer position only to throw it away.) > > Personally, I wish org-id-find would not be removed, because I use it in > org-bookmark-heading, e.g.: > > https://github.com/alphapapa/org-bookmark-heading/blob/master/org-bookmark-heading.el#L126 > > On the other hand, maybe this is a good time to see about getting > org-bookmark-heading into org itself, in which case whoever changes the > API would be responsible for updating it... ;) WDYT? I didn't try your package, but from the description it simply allows one to use the standard Emacs bookmark system, correct? (I’m surprised it doesn’t work with org files out of the box). Such a feature does belong in Org IMO so feel free to start a new thread. Rasmus -- Not everything that goes around comes back around, you know