From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Mon, 07 Nov 2016 10:01:07 +0100 Message-ID: <87oa1r64vg.fsf@gmx.de> References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> <83shrtx5dv.fsf@gnu.org> <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> <877f95deig.fsf@gmx.de> <6f656e32-a44c-f874-3290-f47b8828078e@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1478509360 6803 195.159.176.226 (7 Nov 2016 09:02:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 7 Nov 2016 09:02:40 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Eli Zaretskii , Nikolay Kudryavtsev , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 07 10:02:32 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3fod-0006WI-QB for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 10:02:07 +0100 Original-Received: from localhost ([::1]:52302 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3fog-0001DS-Pa for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 04:02:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3fnp-0001Bn-Lc for emacs-devel@gnu.org; Mon, 07 Nov 2016 04:01:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3fnk-0008O6-AH for emacs-devel@gnu.org; Mon, 07 Nov 2016 04:01:17 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:50328) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3fnk-0008Lc-0J; Mon, 07 Nov 2016 04:01:12 -0500 Original-Received: from detlef.gmx.de ([87.146.53.66]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0Mg4FJ-1cR04X2Yr7-00NSRS; Mon, 07 Nov 2016 10:01:08 +0100 In-Reply-To: <6f656e32-a44c-f874-3290-f47b8828078e@yandex.ru> (Dmitry Gutov's message of "Mon, 7 Nov 2016 02:08:56 +0200") X-Provags-ID: V03:K0:1nVwnLfR4XTM080nhJkIGAvVCve8DfQXMLrwOH+EQcmp3W7SIF2 bBA5mKvCw1BGVCOxnNkw2C+4nA2Flahr6jU6XisYVLS6pR4gC1B3EwfQ34/zYjZZ2Ol/yZF 8uFfJWy3ATIDrm0yTPuLtUdDC70lc0JUsoFmoZxnKXxHuTh1xMlqoLPugghxrvopKQDiiG2 BASncGrzMYbdFj9TMlStw== X-UI-Out-Filterresults: notjunk:1;V01:K0:13sHo76wB/U=:Xx0AcaPUuv9Rt7VO4shnnd l8otc8Urlq4IHR3ZtGWXIj0UB8GjHjPr6SamMS8gIzZt+YKUbaGSuAYLiB/Ps0pZF6z7S3U+b 3En+Go036d+Wz0WXGgpxNiSfIQ7Nu6G8gEY0thv4ErN4ClCe7/NI4AhDthXCxdpW5HQwEPwIq +P16lF01Li6FIJ5+Vtg011vD8IzsdqW4nw3ouNPMas9tbGM1b1Cbuy9hY3zjpTMSLV8kA9x2q CSpLwJR++tKDVYkus+qQaLdm5oQRoc8Sk78UnY4eUqS4Ok5eUdQw4YPd9SNOTBwt5JGWdpffg YTrip9AAoyC5PcXBKg+PBa9snZ82hFNfklb3gdc2zVe8AePEYLFn8ntW/EqP7Z8IQ6phAMFXO Dc2YwnDzNPHjTJK6ftkgTWHcN2/nIdz9t69gWSElZc+VCPQrYmPVcWxM4Lpi94bhj4hPpZ6aX kHOa0UpD9HS+p81g8YSUIW3jjwoMJemAqPZ5tEHNkVpVeAvLsbcAPjfcAX3fNECOVbkBO7Fz3 SdzQArE7+3ITdiJjDu2aSl3bTBPV4yw3lcorFwf2U2oIbQksQkGGWIKfietVjy6QFdL493uxk UEX24yMoXVXKP2xRnbnreen6ejvKWUWhNutB5cP7qCiBizEzXuZLo569IHXQ748AQFLWdGF2b 0FtJJ70Lm+RXQ+mrXaC00vuo33eg6i5U9m5NcdKhLC+wQYfrEQXytyOofndZihKhmYnbvaWR3 UU+pz+R2KRyg6yp0TxEHK8Qq1WBXZvNIPdUYFjTyZXPy87Gsxankd/SkTDmpjesn7ofoDKlF X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209238 Archived-At: Dmitry Gutov writes: > Hi Michael, Hi Dmitry, >> ! (nconc (if msg-file >> ! (list >> ! "commit" "-F" >> ! (or (file-remote-p msg-file 'localname) msg-file)) > > Can't we move the (file-remote-p ... 'localname) call to the first > hunk here? Then the patch will only change one place, and we get rid > of the added `or' here. I let it to Nikolay. However, given that this construct (or (file-remote-p FILE 'localname) FILE) happens several times in the lisp sources, I wonder whether we shall give it an own defmacro or defsubst (in master, of course).