From: npostavs@users.sourceforge.net
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25556@debbugs.gnu.org
Subject: bug#25556: 26.0.50.1; Requiring uncompiled eieio issues obsoletion warnings
Date: Sat, 28 Jan 2017 09:31:37 -0500 [thread overview]
Message-ID: <87o9yrs1bq.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87ziibzigh.fsf@engster.org> (David Engster's message of "Sat, 28 Jan 2017 09:39:42 +0100")
David Engster <deng@randomsample.de> writes:
> Eli Zaretskii writes:
>>> From: David Engster <deng@randomsample.de>
>>> Date: Fri, 27 Jan 2017 21:38:58 +0100
>>>
>>
>>> I'm currently trying to fix compiler warnings during the CEDET compile
>>> in Emacs master, but there's one annoying problem I'm unsure how to
>>> fix. Whenever a file does (require 'eieio), and EIEIO is not yet
>>> byte-compiled, those two warnings are issued:
>>>
>>> ../../emacs-lisp/eieio.el: ‘eieio-object-name-string’ is an obsolete
>>> generic function (as of 25.1); use ‘eieio-named’ instead.
>>> ../../emacs-lisp/eieio.el: ‘destructor’ is an obsolete generic
>>> function (as of 26.1).
>>>
>>> Since EIEIO is compiled pretty late, one is flooded with these warnings
>>> when compiling Emacs master. The warnings seems to come from the
>>> cl-defgeneric for `eieio-object-name-string' and `destructor'. How can
>>> this be dealt with?
>>
>> Is it possibel to arrange that these files be compiled sooner? We
>> already have some targets for similar purposes in lisp/Makefile.
>
> I'm sure that's possible, but why does the file that declares those
> constructs obsolete *itself* throw these warnings? I was hoping that
> this could be fixed instead.
I'm not sure about `eieio-object-name-string', but the message about
`destructor' is because cl-defgeneric makes the declaration handling
code run before the function defining code, so the symbol is declared
obsolete before it's defined and the definition itself triggers the
obsolete warning. The patch below moves it around and stops the
`destructor' warning:
--- i/lisp/emacs-lisp/cl-generic.el
+++ w/lisp/emacs-lisp/cl-generic.el
@@ -226,7 +226,13 @@ cl-defgeneric
(when (eq 'setf (car-safe name))
(require 'gv)
(setq name (gv-setter (cadr name))))
- `(progn
+ `(prog1
+ (progn
+ (defalias ',name
+ (cl-generic-define ',name ',args ',(nreverse options))
+ ,(help-add-fundoc-usage doc args))
+ ,@(mapcar (lambda (method) `(cl-defmethod ,name ,@method))
+ (nreverse methods)))
,@(mapcar (lambda (declaration)
(let ((f (cdr (assq (car declaration)
defun-declarations-alist))))
@@ -235,12 +241,7 @@ cl-defgeneric
(t (message "Warning: Unknown defun property `%S' in %S"
(car declaration) name)
nil))))
- (cdr declarations))
- (defalias ',name
- (cl-generic-define ',name ',args ',(nreverse options))
- ,(help-add-fundoc-usage doc args))
- ,@(mapcar (lambda (method) `(cl-defmethod ,name ,@method))
- (nreverse methods)))))
+ (cdr declarations)))))
;;;###autoload
(defun cl-generic-define (name args options)
next prev parent reply other threads:[~2017-01-28 14:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 20:38 bug#25556: 26.0.50.1; Requiring uncompiled eieio issues obsoletion warnings David Engster
2017-01-28 7:15 ` Eli Zaretskii
2017-01-28 8:39 ` David Engster
2017-01-28 14:31 ` npostavs [this message]
2017-01-28 21:15 ` David Engster
2017-01-29 16:20 ` npostavs
2017-01-29 21:23 ` David Engster
2018-03-16 1:31 ` Glenn Morris
2018-03-16 6:00 ` Glenn Morris
2018-03-16 12:14 ` Stefan Monnier
2018-03-17 0:42 ` Glenn Morris
2020-08-24 15:26 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9yrs1bq.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=25556@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.