From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable Date: Fri, 28 Jul 2017 14:45:24 -0600 Message-ID: <87o9s42suz.fsf@lylat> References: <87d1jrzufs.fsf@gmail.com> <87shizwqca.fsf@lylat> <83k22t3tg9.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1501274779 1804 195.159.176.226 (28 Jul 2017 20:46:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 28 Jul 2017 20:46:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 24543@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 28 22:46:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbC9C-0008SP-T2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jul 2017 22:46:11 +0200 Original-Received: from localhost ([::1]:50018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbC9I-0006Ye-4s for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jul 2017 16:46:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbC99-0006Xs-Pi for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2017 16:46:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbC93-0000FE-UP for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2017 16:46:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57706) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dbC93-0000F7-Pt for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2017 16:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dbC93-0000jD-Ka for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2017 16:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2017 20:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24543-submit@debbugs.gnu.org id=B24543.15012747362763 (code B ref 24543); Fri, 28 Jul 2017 20:46:01 +0000 Original-Received: (at 24543) by debbugs.gnu.org; 28 Jul 2017 20:45:36 +0000 Original-Received: from localhost ([127.0.0.1]:60383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbC8e-0000iV-MM for submit@debbugs.gnu.org; Fri, 28 Jul 2017 16:45:36 -0400 Original-Received: from mail-it0-f49.google.com ([209.85.214.49]:32882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbC8c-0000iH-Ud for 24543@debbugs.gnu.org; Fri, 28 Jul 2017 16:45:35 -0400 Original-Received: by mail-it0-f49.google.com with SMTP id v127so7665316itd.0 for <24543@debbugs.gnu.org>; Fri, 28 Jul 2017 13:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=IM7ABpslEFlWLpep0n63rY3XR7eQ1wiJyNLkkOKQ3ZE=; b=uspBtYHTSD4nhRvayNZUekyTUyUJiOiGHqX272tqDXm3tPHeMzBNAFNp0PrSE3EV0B UcivcGFSGMzS1HWmkacZBVXpn0z5JIvOvkKzs7kaycvp8hqq440kfhbyaHWBwWPKafCY 0rPv62Ti7IaYy1ZHe4s9AmGS/sBzzndfnNuUadBteG7iBTG83ANIeE1DPcuEiIR0XwGg OLUQCtP0WmkNF8lAskuarBUSgjaRPg4eM6zJskNl8n1qWXy02VBq56FBJf4jI0NGOEf3 jEavxjrqRrS1lV6CQWFnH7Y7KdhS3Nmm1i0SjYJCP6kvMD095yeTp/gdYnzJ/WSf2wUb rjmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=IM7ABpslEFlWLpep0n63rY3XR7eQ1wiJyNLkkOKQ3ZE=; b=ozajyXie5lkmSYCRs0HR8DOi/xKKORZEc33gUUp31Gafl8LpTZ1nY2ShtZhUiFGd4P KJg7NGmPsk1GzlAYE5Gzy/HA30oq7WY2jI7lBdv4kU09QVWwLwMZiKvbpqfEI4WAcKIz OVqt4Urj010G8OjA8HeOH6JX0ol0MWI+BdkfLg44Qs8s4eKSNdWcg3xXhSCajXEHmcxj eTtJ8au8pfy1Ea1j6mN10jXHVeuYbloLtDug2WT6XdunlE/CcRrD4T2r8j6LSfV4ZbAv +grFM2der9dQftxbL/juH/d/aYuOt+BdrwtvBc26464aSWQflNmwc5sdR2jtdeg7L4vk u1iw== X-Gm-Message-State: AIVw111m5hYs7f8X32LKzAf4SiQsxTXiao9XIEBCDzX5+4iXX8pB4OWZ gUP8fTG11LRRhkMT X-Received: by 10.36.233.194 with SMTP id f185mr11161298ith.166.1501274729029; Fri, 28 Jul 2017 13:45:29 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id y75sm2602822itb.31.2017.07.28.13.45.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Jul 2017 13:45:28 -0700 (PDT) In-Reply-To: <83k22t3tg9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Jul 2017 10:35:02 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135096 Archived-At: Eli Zaretskii writes: >> From: Alex >> Date: Fri, 16 Jun 2017 15:54:45 -0600 >> >> > emacs -Q >> > C-h o font-lock-comment-face RET >> > >> > Only the variable of this name is shown, not the face (which can be >> > viewed with describe-face, of course). >> > >> > It appears that when the face only shares a name with a function, then >> > both the function and face are shown. Only a variable shadows the face >> > in describe-symbol. >> >> This is because describe-symbol isn't returning (buffer-string) like >> describe-{function, variable} are. >> >> I've attached a patch fixing this problem. > > Thanks. This LGTM, but doesn't the fact that describe-face's return > value will change after this constitute an incompatible change? And I suppose so; would it be expected to be documented in NEWS? > if so, could it break some of the users of this function out there? Potentially, but I don't see that being an issue in this case. The return value isn't documented, so users shouldn't be (and likely aren't) relying on describe-face always returning nil. It makes more sense to treat describe-face like describe-{function, variable}. Though I'm not sure why those two procedures return (buffer-string) in the first place. In any case, I figure it's better to leave those and describe-symbol alone and just make describe-face behave similarly.