From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.devel Subject: Slightly extending commit 16b0520a9 Date: Sat, 05 Aug 2017 21:58:36 -0600 Message-ID: <87o9rtuz2r.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1501991942 12149 195.159.176.226 (6 Aug 2017 03:59:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 Aug 2017 03:59:02 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Paul Eggert To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 06 05:58:52 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deCiJ-0002XE-4m for ged-emacs-devel@m.gmane.org; Sun, 06 Aug 2017 05:58:51 +0200 Original-Received: from localhost ([::1]:59638 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deCiP-0003BA-55 for ged-emacs-devel@m.gmane.org; Sat, 05 Aug 2017 23:58:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deCiD-0003Al-I3 for emacs-devel@gnu.org; Sat, 05 Aug 2017 23:58:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1deCiA-0004yg-GE for emacs-devel@gnu.org; Sat, 05 Aug 2017 23:58:45 -0400 Original-Received: from mail-io0-x243.google.com ([2607:f8b0:4001:c06::243]:34474) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1deCiA-0004yK-Au for emacs-devel@gnu.org; Sat, 05 Aug 2017 23:58:42 -0400 Original-Received: by mail-io0-x243.google.com with SMTP id m88so3476814iod.1 for ; Sat, 05 Aug 2017 20:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:user-agent:mime-version; bh=2k3qK8qnsbVadaHxA745m1n5c9ItdTEE6mDLLhilMPo=; b=HVuxVU65AMEF0w0yfDc4uzWHeT9EHlhaUKRMxbvmb1Iu1flw/OtCI502QegEqAn/GZ FKy2qfyyCCGxEgozc4/coGLtMM6RzNs8h21AzMrXx5Rp6n3WkAreCgII8vrMFZJRG6Rm PVVdJfIoj2Ipo9P7lg/U/f8cFQ8aXCBNDQkMT4yBecO9utkysve9oCaLK1t+mnZEp4yU 6MmUktEHc1N1n5u6A+y5dCkpnfRpMXuG75CHDZK+IABFPW9qf7QWNiDvxjsiRoOriwKr 8jeB9KK0lD0j/iuaApvHANp1dWeyuamZdhlE6xNj7I6YumkB74lukrqZbCXQCTBn7q37 etWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :mime-version; bh=2k3qK8qnsbVadaHxA745m1n5c9ItdTEE6mDLLhilMPo=; b=qecV3tkXKTj+nPGbGL39Jmk+RAwvdhqylwG0MEFqteXrLmwgzC3y1idWEfKG7DqNhN D+Pe0YTkreN5ql+L2KThbepCINtD2sKfEz1KzlmBboBE2c2TpbGHSMOC/+gtlbgbnlNX o5IbtRhwaIZkK/3MaJ2oUrwyTW4Gg2w574PT1ix9+UP9Juonf40FSsEa12RQjoCwiTTc YIUEtQfk/RU9FsaP+pUFtnC0gMFfhycwlDGw8GVuaDmEnmKqw9ssI/7gN1TQo9gSFDTO qhHYgpP6axIImeO5JAsaW0PnJKLDeFS+u04xD7oQqbbZ9KJ5zXFP/BtIg7GgdnhUDpCu UGcQ== X-Gm-Message-State: AIVw111COo5bo8SLgPiRMK5DsI8DvQY66MigRVO6H3h6pSlRWQxK+4Jg eOHBJrxq6XqJbQ== X-Received: by 10.107.175.167 with SMTP id p39mr7060559ioo.83.1501991919810; Sat, 05 Aug 2017 20:58:39 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id c18sm2520689itc.8.2017.08.05.20.58.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Aug 2017 20:58:38 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c06::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217335 Archived-At: Commit 16b0520a9 changed various Fcar/Fcdr calls into XCAR/XCDR, but I believe I see two more instances where this change can also be applied. In both cases, XCDR is already being applied on XCDR (args), so XCAR should also be fine. diff --git a/src/eval.c b/src/eval.c index e5900382de..d132959f0c 100644 --- a/src/eval.c +++ b/src/eval.c @@ -396,7 +396,7 @@ usage: (if COND THEN ELSE...) */) cond = eval_sub (XCAR (args)); if (!NILP (cond)) - return eval_sub (Fcar (XCDR (args))); + return eval_sub (XCAR (XCDR (args))); return Fprogn (XCDR (XCDR (args))); } @@ -806,7 +806,7 @@ usage: (defconst SYMBOL INITVALUE [DOCSTRING]) */) if (CONSP (Fcdr (XCDR (XCDR (args))))) error ("Too many arguments"); - tem = eval_sub (Fcar (XCDR (args))); + tem = eval_sub (XCAR (XCDR (args))); if (!NILP (Vpurify_flag)) tem = Fpurecopy (tem); Fset_default (sym, tem);