all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex <agrambot@gmail.com>
To: emacs-devel@gnu.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: Slightly extending commit 16b0520a9
Date: Sat, 05 Aug 2017 21:58:36 -0600	[thread overview]
Message-ID: <87o9rtuz2r.fsf@lylat> (raw)

Commit 16b0520a9 changed various Fcar/Fcdr calls into XCAR/XCDR, but I
believe I see two more instances where this change can also be applied.
In both cases, XCDR is already being applied on XCDR (args), so XCAR
should also be fine.

diff --git a/src/eval.c b/src/eval.c
index e5900382de..d132959f0c 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -396,7 +396,7 @@ usage: (if COND THEN ELSE...)  */)
   cond = eval_sub (XCAR (args));
 
   if (!NILP (cond))
-    return eval_sub (Fcar (XCDR (args)));
+    return eval_sub (XCAR (XCDR (args)));
   return Fprogn (XCDR (XCDR (args)));
 }
 
@@ -806,7 +806,7 @@ usage: (defconst SYMBOL INITVALUE [DOCSTRING])  */)
   if (CONSP (Fcdr (XCDR (XCDR (args)))))
     error ("Too many arguments");
 
-  tem = eval_sub (Fcar (XCDR (args)));
+  tem = eval_sub (XCAR (XCDR (args)));
   if (!NILP (Vpurify_flag))
     tem = Fpurecopy (tem);
   Fset_default (sym, tem);



             reply	other threads:[~2017-08-06  3:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-06  3:58 Alex [this message]
2017-08-06  4:08 ` Slightly extending commit 16b0520a9 Stefan Monnier
2017-08-06  4:30   ` Alex
2017-08-06 16:18     ` Stefan Monnier
2017-08-07  0:10       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9rtuz2r.fsf@lylat \
    --to=agrambot@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.