From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: [ELPA] Package proposal: EBDB
Date: Tue, 15 Aug 2017 08:30:08 -0700 [thread overview]
Message-ID: <87o9rg4znj.fsf@ericabrahamsen.net> (raw)
In-Reply-To: jwvh8x9jmxl.fsf-monnier+gmane.emacs.devel@gnu.org
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Huh, interesting. Is that function completely deprecated, or still
>> usable for class-allocated slots?
>
> It's fine for class-allocated slots.
>
>>> - ebdb-vm and ebdb-mu4e will break the compilation of the package if the
>>> user doesn't have VM and mu4e installed.
>>> The appended patch tries to fix those two, but please take a look at it
>>> to make sure it still works correctly (especially the ebdb-vm part is
>>> quick&dirty, leaving a lot of warnings when VM is not installed, some
>>> of them may be real bugs).
>> I thought about extracting those two into separate packages, and
>> probably should have done that.
>
> That's one way to solve the problem, but it's not necessary.
>
>> Actually, I do know: vm and mu4e aren't installable via the package
>> manager. If I make separate packages, and put a package-requires header
>> in them for vm and mu4e, will package.el be satisfied if a user has
>> installed them via other means? Or will it bark?
>
> It will bark :-(
>
>> Another option would be a boatload of (autoload 'function "ext:vm")
>> statements.
>
> For ebdb-mu4e, I think the patch I send leads to correct results, so
> I think it's an acceptable solution.
>
> For VM, I'm not sure if the result is correct. It basically depends on
> whether part of the VM code are needed during compilation (most common
> case is if your code uses VM macros).
>
> Fixing the warnings is easy enough (rather than autoloads, you can use
> `declare-function`).
Okay, I'll apply your solution to ebdb-mu4e, then take a closer look at
vm.
Thanks,
Eric
next prev parent reply other threads:[~2017-08-15 15:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-30 19:18 [ELPA] Package proposal: EBDB Eric Abrahamsen
2017-07-31 0:49 ` Richard Stallman
2017-07-31 3:10 ` Eli Zaretskii
2017-07-31 3:12 ` Eric Abrahamsen
2017-07-31 3:28 ` Eli Zaretskii
2017-07-31 3:30 ` Eric Abrahamsen
2017-08-09 21:17 ` Eric Abrahamsen
2017-08-13 1:03 ` Eric Abrahamsen
2017-08-13 21:47 ` Stefan Monnier
2017-08-14 1:44 ` Eric Abrahamsen
2017-08-14 9:45 ` Stefan Monnier
2017-08-14 15:59 ` Eric Abrahamsen
2017-08-14 23:15 ` Stefan Monnier
2017-08-14 23:50 ` Eric Abrahamsen
2017-08-15 7:49 ` Stefan Monnier
2017-08-15 15:30 ` Eric Abrahamsen [this message]
2017-08-17 16:57 ` Eric Abrahamsen
2017-08-17 22:21 ` Stefan Monnier
2017-08-17 22:52 ` Eric Abrahamsen
2017-08-17 23:27 ` Stefan Monnier
2017-08-17 23:31 ` Eric Abrahamsen
2017-08-01 5:33 ` John Wiegley
2017-08-01 16:04 ` Eric Abrahamsen
2017-08-01 22:25 ` John Wiegley
2017-08-01 23:52 ` Eric Abrahamsen
2017-08-02 1:28 ` John Wiegley
2017-08-02 3:08 ` Eric Abrahamsen
2017-08-01 5:58 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2017-08-06 22:12 Roland Winkler
2017-08-07 0:44 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9rg4znj.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.