From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#28605: 26.0.60; Part of leftmost character hidden Date: Fri, 06 Oct 2017 10:37:13 +0200 Organization: not if I can help it Message-ID: <87o9pk65ae.fsf@gmail.com> References: <59CB5D69.7040404@gmx.at> <59CE05F2.1010202@gmx.at> <59CE8E74.5010308@gmx.at> <59D35549.6030905@gmx.at> <87wp4c750c.fsf@gmail.com> <59D4A45F.5010606@gmx.at> <87tvzfjfcp.fsf@gmail.com> <59D5E8F6.8080002@gmx.at> <87efqikk0x.fsf@gmail.com> <87a815lq3w.fsf@gmail.com> <59D73C6F.3020907@gmx.at> Reply-To: bug-gnu-emacs@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507279103 6449 195.159.176.226 (6 Oct 2017 08:38:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Oct 2017 08:38:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) To: 28605@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 06 10:38:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0O94-0000Dg-2X for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Oct 2017 10:38:10 +0200 Original-Received: from localhost ([::1]:43559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0O9B-0001HQ-KS for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Oct 2017 04:38:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0O90-0001H2-Dw for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 04:38:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0O8w-0001Jx-Dk for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 04:38:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43440) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0O8w-0001JO-AH for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 04:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e0O8w-0005t6-1h for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 04:38:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Oct 2017 08:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.150727905822597 (code B ref -1); Fri, 06 Oct 2017 08:38:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Oct 2017 08:37:38 +0000 Original-Received: from localhost ([127.0.0.1]:52121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0O8Y-0005sO-8M for submit@debbugs.gnu.org; Fri, 06 Oct 2017 04:37:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0O8W-0005sC-FJ for submit@debbugs.gnu.org; Fri, 06 Oct 2017 04:37:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0O8Q-0000qG-Ia for submit@debbugs.gnu.org; Fri, 06 Oct 2017 04:37:31 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:35029) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e0O8Q-0000q6-Es for submit@debbugs.gnu.org; Fri, 06 Oct 2017 04:37:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0O8P-00014W-4L for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 04:37:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0O8L-0000ig-MI for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 04:37:29 -0400 Original-Received: from [195.159.176.226] (port=52769 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0O8L-0000gp-Eg for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 04:37:25 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1e0O89-0002eL-0X for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 10:37:13 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org Original-Lines: 43 Original-X-Complaints-To: usenet@blaine.gmane.org Mail-Copies-To: never Cancel-Lock: sha1:+P4BgfZYtymXfVlYuegmVnHOIJA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138004 Archived-At: martin rudalics writes: >> Thinking about this some more, this whole calculation just looks >> wrong. oldx, oldw, oldw and oldh are in unscaled pixels, as far as I >> can tell. We need to scale when using GTK routines, but x_clear_area >> ends up calling X11 routines, so I've almost convinced myself that we >> should in fact delete the oldw and oldx adjustments for the vertical >> scrollbar rather than adding them for the horizontal one. > > Be sure to distinguish code that decides where to draw a scroll bar from > code that decides which area to clear and possibly redraw. Sometimes, > the area that gets cleared can be substantially larger than the area > occupied by a toolkit scroll bar. From my experience, this is often > noticeable with GTK scroll bars since their width is determined by the > chosen theme and cannot be adjusted individually by Emacs. OK. The best course of action is then probably not to touch the existing adjustments, and not to add any similar ones for the horizontal case. >> That code was added in commit c0055ff5b03c9121ab5bf752496b09416f0f0a7d >> which is quite old, > > ... 2015 rather strikes me as "fairly recent" ... > Oops, I think I looked at the date on the wrong commit, I thought I'd seen 2010. >> I suspect it did no real harm even though oldx >> tends to end up negative, possibly x_clear_area does some kind of >> clipping. > > In my experience, X silently swallows anything that happens outside the > frame. GTK can be much more picky in this regard, especially when > trying to draw something outside a parent widget. But the corresponding > error messages are usually a pain to read. Yet another reason not to disturb the status quo. Regards Robert