From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Win Treese <treese@acm.org>
Cc: Dmitri Paduchikh <dpaduchikh@gmail.com>, 24573@debbugs.gnu.org
Subject: bug#24573: 25.1; Setting bookmark in buffer *Help* makes bookmarks non-loadable
Date: Sat, 28 Oct 2017 15:48:17 -0400 [thread overview]
Message-ID: <87o9orawam.fsf@users.sourceforge.net> (raw)
In-Reply-To: <F8FD83A3-4794-4E2D-A614-153075C91905@acm.org> (Win Treese's message of "Sat, 28 Oct 2017 14:53:59 -0400")
Win Treese <treese@acm.org> writes:
> Finding the problem:
>
> The problem appears to be in the definition for describe-function i
> help-fns.el. help-setup-xref is called with a lambda instead of a
> function symbol (as it was before this code was changed).
> When the bookmark is saved, the syntax for the lambda is not
> parsable by read to restore it.
The lambda is fine, it's the buffer which uses the unreadable print
synax: #<...>. The following which swaps buffer objects with their name
seems to fix it, although I haven't really tested this much.
--- i/lisp/help-mode.el
+++ w/lisp/help-mode.el
@@ -756,7 +756,9 @@ help-bookmark-make-record
(error "Cannot create bookmark - help command not known"))
`(,@(bookmark-make-record-default 'NO-FILE 'NO-CONTEXT)
(help-fn . ,(car help-xref-stack-item))
- (help-args . ,(cdr help-xref-stack-item))
+ (help-args . ,(mapcar (lambda (a)
+ (if (bufferp a) (buffer-name a) a))
+ (cdr help-xref-stack-item)))
(position . ,(point))
(handler . help-bookmark-jump)))
next prev parent reply other threads:[~2017-10-28 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 14:13 bug#24573: 25.1; Setting bookmark in buffer *Help* makes bookmarks non-loadable Dmitri Paduchikh
2017-10-28 18:53 ` Win Treese
2017-10-28 19:48 ` Noam Postavsky [this message]
2019-07-02 16:22 ` Stefan Kangas
2019-07-06 18:42 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9orawam.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=24573@debbugs.gnu.org \
--cc=dpaduchikh@gmail.com \
--cc=treese@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.