all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Robert Weiner <rswgnu@gmail.com>
Cc: 23623@debbugs.gnu.org
Subject: bug#23623: Patch to improve function options in find-func.el
Date: Mon, 06 Nov 2017 20:03:38 -0500	[thread overview]
Message-ID: <87o9oe6gt1.fsf@users.sourceforge.net> (raw)
In-Reply-To: <CA+OMD9gjKpRMy_s9XiKqsArfCB2ZoTxrSqYXnKTdZn6Ymrjxvw@mail.gmail.com> (Robert Weiner's message of "Thu, 26 May 2016 11:52:09 -0400")

Robert Weiner <rswgnu@gmail.com> writes:

> Note that the one large patch section of one function is really just a
> change of a line at the end of the function but diff generated a large
> context patch for it, maybe the indentation changed.

The patch seems to have got mangled by some line wrapping and similar.
Please send as attachment instead.  Please don't post to both
emacs-devel and bug-gnu-emacs.

> Please let me know if these changes are acceptable.  They provide many
> benefits to potential callers of this package and make the *-noselect
> functions more straightforward to use.

I think it's okay for master.

> +Visit the library in a buffer, and return a (buffer . position) pair,

The convention we use in docstrings is that placeholders in structures
should be in upper case.  The way you wrote it here would be describing
a function which does (cons 'buffer 'position).





  reply	other threads:[~2017-11-07  1:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 15:52 Patch to improve function options in find-func.el Robert Weiner
2017-11-07  1:03 ` Noam Postavsky [this message]
2017-12-18  4:33   ` bug#23623: " Robert Weiner
2017-12-18 16:07     ` Eli Zaretskii
2017-12-18 16:24       ` Robert Weiner
2017-12-18 16:49         ` Eli Zaretskii
2019-11-08  4:16         ` Stefan Kangas
2020-08-11 15:25           ` Lars Ingebrigtsen
2020-08-11 15:36             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9oe6gt1.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=23623@debbugs.gnu.org \
    --cc=rswgnu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.