bug#29329: 27.0.50; Missing requirement in org-gnus.el

bug#29329: 27.0.50; Missing requirement in org-gnus.el

[Michael Heerdegen]

Hello,

in help-gnu-emacs, a user (CC'd) asked for help because he got this error:


| Debugger entered--Lisp error: (invalid-function
| gnus-summary-article-header)
|   gnus-summary-article-header()
|   org-gnus-store-link()
|   #f(compiled-function (f) #<bytecode 0x174a15d>)(org-gnus-store-link)
|   mapcar(#f(compiled-function (f) #<bytecode 0x174a15d>)
| (org-rmail-store-link org-mhe-store-link org-irc-store-link
| org-info-store-link org-gnus-store-link org-docview-store-link
| org-bibtex-store-link org-bbdb-store-link org-w3m-store-link
| elfeed-link-store-link))
|   org-store-link(nil)
|   funcall-interactively(org-store-link nil)
|   #<subr call-interactively>(org-store-link nil nil)
|   apply(#<subr call-interactively> org-store-link (nil nil))
|   call-interactively@ido-cr+-record-current-command(#<subr
| call-interactively> org-store-link nil nil)
|   apply(call-interactively@ido-cr+-record-current-command #<subr
| call-interactively> (org-store-link nil nil))
|   call-interactively(org-store-link nil nil)
|   command-execute(org-store-link)

Apparently, the function `org-gnus-store-link' in org-gnus.el had been
compiled without the macro `gnus-summary-article-header' (from
gnus-sum.el) defined.  There is apparently a missing requirement at
least when compiling (and at least here on master) in org-gnus.

Erik Abrahamsen (also CC'd) answered that even more requirements might
be missing, like

(eval-when-compile
  (require 'gnus-sum)
  (require 'nnheader)
  (require 'nnir))


TIA,

Michael.



In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.24)
 of 2017-11-14 built on drachen
Repository revision: aef77fff418bb8aaa7bb6b88252f9d74869cf52a
Windowing system distributor 'The X.Org Foundation', version 11.0.11905000
System Description:	Debian GNU/Linux testing (buster)

bug#29329: 27.0.50; Missing requirement in org-gnus.el

[Eric Abrahamsen]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Hello,
>
> in help-gnu-emacs, a user (CC'd) asked for help because he got this error:
>
>
> | Debugger entered--Lisp error: (invalid-function
> | gnus-summary-article-header)
> |   gnus-summary-article-header()
> |   org-gnus-store-link()
> |   #f(compiled-function (f) #<bytecode 0x174a15d>)(org-gnus-store-link)
> |   mapcar(#f(compiled-function (f) #<bytecode 0x174a15d>)
> | (org-rmail-store-link org-mhe-store-link org-irc-store-link
> | org-info-store-link org-gnus-store-link org-docview-store-link
> | org-bibtex-store-link org-bbdb-store-link org-w3m-store-link
> | elfeed-link-store-link))
> |   org-store-link(nil)
> |   funcall-interactively(org-store-link nil)
> |   #<subr call-interactively>(org-store-link nil nil)
> |   apply(#<subr call-interactively> org-store-link (nil nil))
> |   call-interactively@ido-cr+-record-current-command(#<subr
> | call-interactively> org-store-link nil nil)
> |   apply(call-interactively@ido-cr+-record-current-command #<subr
> | call-interactively> (org-store-link nil nil))
> |   call-interactively(org-store-link nil nil)
> |   command-execute(org-store-link)
>
> Apparently, the function `org-gnus-store-link' in org-gnus.el had been
> compiled without the macro `gnus-summary-article-header' (from
> gnus-sum.el) defined.  There is apparently a missing requirement at
> least when compiling (and at least here on master) in org-gnus.
>
> Erik Abrahamsen (also CC'd) answered that even more requirements might
> be missing, like

I guess this should probably be floated on the org-mode list, where it's
most likely to reach the people who will know what to do -- I'll
cross-post now.

Eric

bug#29329: 27.0.50; Missing requirement in org-gnus.el

[Glenn Morris]

In org-gnus-store-link:
org-gnus.el:121:49:Warning: reference to free variable ‘gnus-newsgroup-name’
org-gnus.el:127:42:Warning: reference to free variable ‘gnus-summary-buffer’

In org-gnus-follow-link:
org-gnus.el:203:9:Warning: reference to free variable ‘gnus-other-frame-object’

In end of data:
org-gnus.el:243:1:Warning: the following functions are not known to be
    defined: gnus-group-group-name, gnus-find-method-for-group,
    gnus-summary-article-number, nnir-article-group,
    gnus-summary-article-header, mail-header-from, mail-header-id,
    mail-header-date, mail-header-subject, mail-header-extra,
    gnus-summary-select-article, message-narrow-to-headers,
    message-generate-headers, message-unquote-tokens,
    message-tokenize-header,
    gnus-activate-group, gnus-group-read-group,
    gnus-summary-goto-article,
    gnus-group-jump-to-group


(These issues are all hidden if org-gnus.elc is created before org.elc.)


PS hey emacs-orgmode: https://debbugs.gnu.org/org-mode

bug#29329: 27.0.50; Missing requirement in org-gnus.el

[Nicolas Goaziou]

Hello,

Glenn Morris <rgm@gnu.org> writes:

> In org-gnus-store-link:
> org-gnus.el:121:49:Warning: reference to free variable ‘gnus-newsgroup-name’
> org-gnus.el:127:42:Warning: reference to free variable ‘gnus-summary-buffer’
>
> In org-gnus-follow-link:
> org-gnus.el:203:9:Warning: reference to free variable ‘gnus-other-frame-object’
>
> In end of data:
> org-gnus.el:243:1:Warning: the following functions are not known to be
>     defined: gnus-group-group-name, gnus-find-method-for-group,
>     gnus-summary-article-number, nnir-article-group,
>     gnus-summary-article-header, mail-header-from, mail-header-id,
>     mail-header-date, mail-header-subject, mail-header-extra,
>     gnus-summary-select-article, message-narrow-to-headers,
>     message-generate-headers, message-unquote-tokens,
>     message-tokenize-header,
>     gnus-activate-group, gnus-group-read-group,
>     gnus-summary-goto-article,
>     gnus-group-jump-to-group
>
>
> (These issues are all hidden if org-gnus.elc is created before
> org.elc.)

I think I fixed those. Is there any left?

Thank you.

Regards,

-- 
Nicolas Goaziou

bug#29329: 27.0.50; Missing requirement in org-gnus.el

[Glenn Morris]

Speaking for the version in Emacs, apart from org-gnus the warnings are:

In end of data:
org-irc.el:255:1:Warning: the following functions are not known to be defined:
    erc-save-buffer-in-logs, erc-logging-enabled

(I haven't looked at the code.)

bug#29329: 27.0.50; Missing requirement in org-gnus.el

[Nicolas Goaziou]

Hello,

Glenn Morris <rgm@gnu.org> writes:

> Speaking for the version in Emacs, apart from org-gnus the warnings are:
>
> In end of data:
> org-irc.el:255:1:Warning: the following functions are not known to be defined:
>     erc-save-buffer-in-logs, erc-logging-enabled

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

Re: 27.0.50;Missing requirement in org-gnus.el

[Rasmus]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Glenn Morris <rgm@gnu.org> writes:
>
>> Speaking for the version in Emacs, apart from org-gnus the warnings are:
>>
>> In end of data:
>> org-irc.el:255:1:Warning: the following functions are not known to be defined:
>>     erc-save-buffer-in-logs, erc-logging-enabled
>
> Fixed. Thank you.

Should we prepare another v9.1 bugfix release for the next version of
Emacs?

Rasmus

-- 
Evidence suggests Snowden used a powerful tool called monospaced fonts

Re: 27.0.50;Missing requirement in org-gnus.el

[Nicolas Goaziou]

Hello,

Rasmus <rasmus@gmx.us> writes:

> Should we prepare another v9.1 bugfix release for the next version of
> Emacs?

It would be great. Org 9.1.3 contains a nasty fontification bug. We
certainly don't want that in Emacs 26.1.

Regards,

-- 
Nicolas Goaziou

Re: 27.0.50;Missing requirement in org-gnus.el

[Bastien Guerry]

Hi Nicolas and Rasmus,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> It would be great. Org 9.1.3 contains a nasty fontification bug. We
> certainly don't want that in Emacs 26.1.

I've just released 9.1.4 which fixes this bug, this minor release can
be merged into Emacs.

Thanks,

-- 
 Bastien

Re: 27.0.50;Missing requirement in org-gnus.el

[Kyle Meyer]

Bastien Guerry <bzg@gnu.org> writes:

> I've just released 9.1.4 which fixes this bug, this minor release can
> be merged into Emacs.

Thanks, Bastien.  Rasmus, the emacs-sync branch is ready.

-- 
Kyle

Re: 27.0.50;Missing requirement in org-gnus.el

[Bastien Guerry]

Kyle Meyer <kyle@kyleam.com> writes:

> Bastien Guerry <bzg@gnu.org> writes:
>
>> I've just released 9.1.4 which fixes this bug, this minor release can
>> be merged into Emacs.
>
> Thanks, Bastien.  Rasmus, the emacs-sync branch is ready.

Wow, that was fast.  Thanks a lot Kyle!

-- 
 Bastien

Re: 27.0.50;Missing requirement in org-gnus.el

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

On Tue, Dec 5, 2017 at 7:17 AM Rasmus <rasmus@gmx.us> wrote:

> Should we prepare another v9.1 bugfix release for the next version of
> Emacs?
>


*Neki aur pooch pooch *

It's an idiom in Hindi language which sort of translates[1] to "Why ask
before doing a good deed?". I tried to find something equivalent in English
but couldn't :)

[1]: https://www.google.com/search?q=neki+aur+pooch+pooch
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 946 bytes --]

Re: 27.0.50;Missing requirement in org-gnus.el

[Rasmus]

Kaushal Modi <kaushal.modi@gmail.com> writes:

> On Tue, Dec 5, 2017 at 7:17 AM Rasmus <rasmus@gmx.us> wrote:
>
>> Should we prepare another v9.1 bugfix release for the next version of
>> Emacs?
>>
>
>
> *Neki aur pooch pooch *
>
> It's an idiom in Hindi language which sort of translates[1] to "Why ask
> before doing a good deed?". I tried to find something equivalent in English
> but couldn't :)

Thanks for the new proverb.  I am not sure I would know how to pronounce
it.

To be honest, I am not sure what Bastien does to prepare a release.  I
have tried to document up-stream syncing bit.

Rasmus

-- 
Slowly unravels in a ball of yarn and the devil collects it

Re: 27.0.50;Missing requirement in org-gnus.el

[Bastien Guerry]

Hi Rasmus,

Rasmus <rasmus@gmx.us> writes:

> To be honest, I am not sure what Bastien does to prepare a release.  I
> have tried to document up-stream syncing bit.

Most of what I do is documented in README_maintainer.org.

On the orgmode.org server, I run:

~$ make release
~$ make upload

I do

~$ make doc
~$ make upload-doc
~$ make elpa
~$ make upload-elpa
~$ make elpaplus
~$ make upload-elpaplus

I also update orgweb.git to display the correct version number and to
fix the download URLs.

The whole process takes about 10 minutes.

-- 
 Bastien