From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.bugs Subject: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren Date: Tue, 02 Jan 2018 09:55:47 +0100 Message-ID: <87o9mchc6k.fsf@mbork.pl> References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1514883254 23539 195.159.176.226 (2 Jan 2018 08:54:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Jan 2018 08:54:14 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 27.0.50 Cc: 20871@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 02 09:54:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWIKn-0005jz-0g for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 09:54:09 +0100 Original-Received: from localhost ([::1]:35233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWIMk-0002eg-Rj for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 03:56:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWIMf-0002eT-HR for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 03:56:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWIMc-0003UW-Bb for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 03:56:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51743) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWIMc-0003U9-8J for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 03:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eWIMb-0005dU-UD for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 03:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Marcin Borkowski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jan 2018 08:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20871-submit@debbugs.gnu.org id=B20871.151488335521651 (code B ref 20871); Tue, 02 Jan 2018 08:56:01 +0000 Original-Received: (at 20871) by debbugs.gnu.org; 2 Jan 2018 08:55:55 +0000 Original-Received: from localhost ([127.0.0.1]:60424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWIMV-0005d8-Kj for submit@debbugs.gnu.org; Tue, 02 Jan 2018 03:55:55 -0500 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:32827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWIMR-0005cx-Hq for 20871@debbugs.gnu.org; Tue, 02 Jan 2018 03:55:52 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id D2686E6691; Tue, 2 Jan 2018 09:55:49 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id smZGM4FV-s5Z; Tue, 2 Jan 2018 09:55:46 +0100 (CET) Original-Received: from localhost (static-dwadziewiec-jedenpiec7.echostar.pl [109.232.29.157]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 7347BE6034; Tue, 2 Jan 2018 09:55:46 +0100 (CET) In-reply-to: <83a7yepuby.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141708 Archived-At: On 2017-12-19, at 17:15, Eli Zaretskii wrote: >> So I did take a look. The mention in the manual is already there, >> I forgot I did that back then. > > Right, sorry I missed that somehow. No problem. >> Where should I put the tests? >> I expected something in e.g. test/lisp/textmodes/fill.el, but there's >> nothing like that there. > > If the file doesn't exist, create it. > >> Also, should I test only my function, or filling with it, or both? > > I think filling with your function is the most important thing to > test. > > Thanks. So that's what I did (see commit 1ad94a126b on branch fix/bug-20871, http://git.savannah.gnu.org/cgit/emacs.git/log/?h=fix/bug-20871). Is that ok? I admit that these tests are rather simplistic, and I'm still not sure about my commit message. Best, -- Marcin Borkowski