From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix frameset-restore in the presence of scaling Date: Mon, 22 Jan 2018 11:58:34 +0100 Message-ID: <87o9lmkvmt.fsf@gmail.com> References: <87efmnb5kr.fsf@gmail.com> <5A623F25.5090604@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516618658 13049 195.159.176.226 (22 Jan 2018 10:57:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 Jan 2018 10:57:38 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 22 11:57:33 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edZn1-0002ZK-O8 for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 11:57:23 +0100 Original-Received: from localhost ([::1]:34870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edZp0-00010L-CB for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 05:59:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edZoH-000107-HM for emacs-devel@gnu.org; Mon, 22 Jan 2018 05:58:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edZoE-0002i3-GE for emacs-devel@gnu.org; Mon, 22 Jan 2018 05:58:41 -0500 Original-Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:40652) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edZoE-0002hL-AI for emacs-devel@gnu.org; Mon, 22 Jan 2018 05:58:38 -0500 Original-Received: by mail-wm0-x236.google.com with SMTP id v123so15913810wmd.5 for ; Mon, 22 Jan 2018 02:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=gOCYqHu3rgh3mLHnh3UbE5OhdaXj62kTm14i8H5mImg=; b=HBeJqeFbnVXqpxxA4PDbdauhKNAllNEl7EzBs8YenFp1CWsk8VpsoHgep8Pk2l9mRE d4gGSeh9Kgt3iYLHr0+3OpEico0u/jcI6B+Jq5lAGLOQVmtNf0Bvi1adjITMhk1qwWPS ua9+So3v9hU2IGrcIYZPimvEGhVUf2Uj/erXBR7kB2xx0k/z0edaELZNDJE74TnY6sXs HIIR2xBCK8xxMgMxU9yvA0CyiPoA6Eh7v+HuDKPGYHpQuC06EX2mu/9zsruAjTaPRTMK Ns3awRZRZ5xDVXFxY9j5nXNmJ7TGI5Nsj3jNMy5t57gJwD53T7oO3hQATVH20IltPkrV aeWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=gOCYqHu3rgh3mLHnh3UbE5OhdaXj62kTm14i8H5mImg=; b=YN4pKlVr62cfF3EkYmSpOoLDA+t26iLLmNWpaWq9HY16NAo6yOYrmi5ROadM/JUR2W y5wN6ObpTtnLdSNS+w9qKR5U0FE92RDpr2Zw1vJCOYvkmB6LMIcvaEn9pc4yXaIJKEv2 3iAxrE4iANabtOaU8orpScbtc+GR3eY4DNYOaB7+yR0bGEpuAwslG/kDzQ5WK3WT6kj6 WFUl7DVG9DeMKCb4qa3Ta3KLY/ykJzhB3SObKF0BGLRBtBQYU3vLaxb/Ksjj57PcMDP7 sxU3Yyt+UZ1DzVldCDhfbjR4vPj5Z/Bo1Qqze2LgyclOymsHmbnRPuiDZc9uBeXZOH2z Xsrw== X-Gm-Message-State: AKwxytcZ/wsOczgtgIJ1/nnYwUzqQyJeDqk5ScOwy6uIf6jEpvUQxNb4 QOIWNl+5SZwV565QoTdmyLnnnT88 X-Google-Smtp-Source: AH8x224Kd+6XSarK0+Wb0XTe9oKmocGr7YaFV164gJ7aqQ3sFQSXC/GjOcfZLU7gFGVJ46tlCBf/4g== X-Received: by 10.28.105.214 with SMTP id z83mr5145643wmh.77.1516618716435; Mon, 22 Jan 2018 02:58:36 -0800 (PST) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id p29sm10039795wmf.20.2018.01.22.02.58.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 02:58:35 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <5A623F25.5090604@gmx.at> (martin rudalics's message of "Fri, 19 Jan 2018 19:55:33 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222135 Archived-At: martin rudalics writes: >> Running emacs-26 with GDK_SCALING=2, frameset-restore will position >> 2nd and subsequent frames incorrectly if they are in the right half of >> the screen. Turns out that we're querying GTK for the dimensions of >> the display in order to ensure that frames remain on-screen, and those >> dimensions need scaling. Patch attached, tested on GTK 3.18, I'd >> appreciate if someone with a HiDPI screen and GTK >= 3.22 could >> confirm whether it works for them. > > When 'left' and top' are negative, they specify a frame position > relative to the right or bottom edge of the display. Are such > specifications affected/corrected by your patch with scaling on? They will almost certainly be corrected. My testcase involved destop-save, which doesn't use such specifications for frames as far as I know, I'll have to do some manual testing. Robert