From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#30162: 27.0.50; Wrong order of directories in *Deletions* Date: Tue, 23 Jan 2018 23:56:44 +0200 Organization: LINKOV.NET Message-ID: <87o9lk6xy8.fsf@mail.linkov.net> References: <87y3kvm5ox.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1516745078 29186 195.159.176.226 (23 Jan 2018 22:04:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Jan 2018 22:04:38 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) To: 30162@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 23 23:04:34 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee6fu-0006IB-Fb for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 23:04:14 +0100 Original-Received: from localhost ([::1]:56433 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee6hu-00051K-SF for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 17:06:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee6hi-00050j-L4 for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 17:06:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee6he-0004M9-ID for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 17:06:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60433) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee6he-0004LD-Eh for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 17:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee6hd-0001yL-TS for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 17:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jan 2018 22:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30162-submit@debbugs.gnu.org id=B30162.15167451217512 (code B ref 30162); Tue, 23 Jan 2018 22:06:01 +0000 Original-Received: (at 30162) by debbugs.gnu.org; 23 Jan 2018 22:05:21 +0000 Original-Received: from localhost ([127.0.0.1]:40097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee6gy-0001x5-To for submit@debbugs.gnu.org; Tue, 23 Jan 2018 17:05:21 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:60189 helo=homiemail-a21.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee6gw-0001wl-65 for 30162@debbugs.gnu.org; Tue, 23 Jan 2018 17:05:18 -0500 Original-Received: from homiemail-a21.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a21.g.dreamhost.com (Postfix) with ESMTP id BD6E21C0065 for <30162@debbugs.gnu.org>; Tue, 23 Jan 2018 14:05:17 -0800 (PST) Original-Received: from localhost.linkov.net (m91-129-108-180.cust.tele2.ee [91.129.108.180]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a21.g.dreamhost.com (Postfix) with ESMTPSA id 1F90D1C0062 for <30162@debbugs.gnu.org>; Tue, 23 Jan 2018 14:05:16 -0800 (PST) In-Reply-To: <87y3kvm5ox.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 18 Jan 2018 23:34:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142449 Archived-At: > This is a regression. The order of directories in *Deletions* was righ= t > in older versions, but not now. > > Steps to reproduce: > > 0. emacs -Q > 1. =E2=80=98M-!=E2=80=99 mkdir x y z RET > 2. =E2=80=98C-x d=E2=80=99 RET > 3. =E2=80=98D D D=E2=80=99 (select dirs x, y, z for deletion) > 4. =E2=80=98x=E2=80=99 (dired-do-flagged-delete) > > Directories in *Deletions* are reversed: > > z > y > x > > It seems this is a result of the commit 9ecbdee, but I can't find > a related discussion. > > I think we should either reverse the list of buffers at the lowest leve= l > in =E2=80=98dired-map-over-marks=E2=80=99 (this might cause backward-co= mpatibility > issues), or don't call =E2=80=98nreverse=E2=80=99 twice and remove =E2=80= =98nreverse=E2=80=99 from > =E2=80=98dired-internal-do-deletions=E2=80=99. This patch is for the latter: diff --git a/lisp/dired.el b/lisp/dired.el index eebf836..eade11b 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -3094,7 +3094,7 @@ dired-internal-do-deletions (dired-recursive-deletes dired-recursive-deletes) (trashing (and trash delete-by-moving-to-trash))) ;; canonicalize file list for pop up - (setq files (nreverse (mapcar #'dired-make-relative files))) + (setq files (mapcar #'dired-make-relative files)) (if (dired-mark-pop-up " *Deletions*" 'delete files dired-deletion-confirmer (format "%s %s "