From: Juri Linkov <juri@linkov.net>
To: 30162@debbugs.gnu.org
Subject: bug#30162: 27.0.50; Wrong order of directories in *Deletions*
Date: Tue, 23 Jan 2018 23:56:44 +0200 [thread overview]
Message-ID: <87o9lk6xy8.fsf@mail.linkov.net> (raw)
In-Reply-To: <87y3kvm5ox.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 18 Jan 2018 23:34:38 +0200")
> This is a regression. The order of directories in *Deletions* was right
> in older versions, but not now.
>
> Steps to reproduce:
>
> 0. emacs -Q
> 1. ‘M-!’ mkdir x y z RET
> 2. ‘C-x d’ RET
> 3. ‘D D D’ (select dirs x, y, z for deletion)
> 4. ‘x’ (dired-do-flagged-delete)
>
> Directories in *Deletions* are reversed:
>
> z
> y
> x
>
> It seems this is a result of the commit 9ecbdee, but I can't find
> a related discussion.
>
> I think we should either reverse the list of buffers at the lowest level
> in ‘dired-map-over-marks’ (this might cause backward-compatibility
> issues), or don't call ‘nreverse’ twice and remove ‘nreverse’ from
> ‘dired-internal-do-deletions’.
This patch is for the latter:
diff --git a/lisp/dired.el b/lisp/dired.el
index eebf836..eade11b 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -3094,7 +3094,7 @@ dired-internal-do-deletions
(dired-recursive-deletes dired-recursive-deletes)
(trashing (and trash delete-by-moving-to-trash)))
;; canonicalize file list for pop up
- (setq files (nreverse (mapcar #'dired-make-relative files)))
+ (setq files (mapcar #'dired-make-relative files))
(if (dired-mark-pop-up
" *Deletions*" 'delete files dired-deletion-confirmer
(format "%s %s "
next prev parent reply other threads:[~2018-01-23 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 21:34 bug#30162: 27.0.50; Wrong order of directories in *Deletions* Juri Linkov
2018-01-23 21:56 ` Juri Linkov [this message]
2018-01-24 21:44 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9lk6xy8.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=30162@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.