From: Robert Cochran <robert+Emacs@cochranmail.com>
To: emacs-devel@gnu.org
Subject: [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/
Date: Wed, 21 Feb 2018 10:30:24 -0800 [thread overview]
Message-ID: <87o9kii4an.fsf@cochranmail.com> (raw)
Hello emacs-devel!
Now that the byte-compile-error-on-warn patch was merged (thanks by the
way!), this is the next step: I've marked most every file in lisp/
that currently byte-compiles without warnings with
'byte-compile-error-on-warn: t' in its file local variables.
I did an absolutely from-scratch build and it completed succesfully, as
well as running the full test suite with no significant errors. I may
have missed some files that should have been marked, but I took care to
*not* mark any files that had errors in them. The intended goal is to
not break the build, but have files that are already warning-free not
grow warnings. Files that still have warnings can be fixed as we go, ala
lexical-binding.
So, it's my understanding that there are some portions of what's in
emacs.git - org-mode being the prominent example in my mind - are simply
merges of a separate repository into emacs.git. Will it be necessary to
submit patches to the 'child' repositories rather than here? If so, how
can I find out which files are from said repositories?
This patch is rather large - the email patch form is 600k. The reason
for this is that I've touched quite a number of files - over 1,000
according to the Gitlab interface.
Thusly, I'm opting to link to the commit from my copy of the repository
rather than attach directly:
https://gitlab.com/RobertCochran/emacs/commit/f8446de4525910cf24dab7635124c3227c1ed1be
Gitlab also has the email form for convenience:
https://gitlab.com/RobertCochran/emacs/commit/f8446de4525910cf24dab7635124c3227c1ed1be.patch
Comments, suggestions, concerns, all that good stuff warmly welcomed.
Thanks,
--
~Robert Cochran
GPG Fingerprint - BD0C 5F8B 381C 64F0 F3CE E7B9 EC9A 872C 41B2 77C2
next reply other threads:[~2018-02-21 18:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 18:30 Robert Cochran [this message]
2018-02-21 18:42 ` [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/ Eli Zaretskii
2018-02-22 2:51 ` Robert Cochran
2018-02-22 6:56 ` Eli Zaretskii
2018-02-21 19:24 ` Stefan Monnier
2018-02-22 3:05 ` Robert Cochran
2018-02-22 5:24 ` Stefan Monnier
2018-02-22 7:18 ` Eli Zaretskii
2018-02-23 9:47 ` Richard Stallman
2018-02-24 11:08 ` Eli Zaretskii
2018-02-24 23:33 ` Richard Stallman
2018-02-25 3:33 ` Eli Zaretskii
2018-02-25 13:13 ` Stefan Monnier
2018-02-25 15:33 ` Eli Zaretskii
2018-02-22 7:13 ` Eli Zaretskii
2018-02-21 19:26 ` Noam Postavsky
2018-02-22 2:29 ` Robert Cochran
2018-02-22 3:24 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9kii4an.fsf@cochranmail.com \
--to=robert+emacs@cochranmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.