bug#31840: and-let* expands to if instead of when

bug#31840: and-let* expands to if instead of when

[Jonas Bernoulli]

(and-let* ((a 'a))
  (body-1)
  (body-n))

expands to

(let* ((a (and t 'a)))
  (if a
      (body-1)
    (body-n)))

but according to its doc-string ("Like `when-let*'...")
it is supposed to expand to

(let* ((a (and t 'a)))
  (if a
      (progn
        (body-1)
        (body-n))))

bug#31840: and-let* expands to if instead of when

[Michael Heerdegen]

Jonas Bernoulli <jonas@bernoul.li> writes:

> (and-let* ((a 'a))
>   (body-1)
>   (body-n))
>
> expands to
>
> (let* ((a (and t 'a)))
>   (if a
>       (body-1)
>     (body-n)))
>
> but according to its doc-string ("Like `when-let*'...")
> it is supposed to expand to
>
> (let* ((a (and t 'a)))
>   (if a
>       (progn
>         (body-1)
>         (body-n))))

Good catch.

Looks like a typo - the `if' should just be a `when'.  Mark, can you
have a look?


Thanks,

Michael.

bug#31840: and-let* expands to if instead of when

[Mark Oteiza]

On 15/06/18 at 06:10am, Michael Heerdegen wrote:
> Jonas Bernoulli <jonas@bernoul.li> writes:
> 
> > (and-let* ((a 'a))
> >   (body-1)
> >   (body-n))
> >
> > expands to
> >
> > (let* ((a (and t 'a)))
> >   (if a
> >       (body-1)
> >     (body-n)))
> >
> > but according to its doc-string ("Like `when-let*'...")
> > it is supposed to expand to
> >
> > (let* ((a (and t 'a)))
> >   (if a
> >       (progn
> >         (body-1)
> >         (body-n))))
> 
> Good catch.
> 
> Looks like a typo - the `if' should just be a `when'.  Mark, can you
> have a look?

Oh my…  I agree, changed in 5b9cc150

bug#31840: and-let* expands to if instead of when

[Michael Heerdegen]

Mark Oteiza <mvoteiza@udel.edu> writes:

> Oh my…  I agree, changed in 5b9cc150

Thanks.

I guess we can close this report.


Michael.

bug#31840: and-let* expands to if instead of when

[Mark Oteiza]

On Tue, Jun 19, 2018 at 1:52 AM, Michael Heerdegen
<michael_heerdegen@web.de> wrote:
> Mark Oteiza <mvoteiza@udel.edu> writes:
>
>> Oh my…  I agree, changed in 5b9cc150
>
> Thanks.
>
> I guess we can close this report.

I forgot about that part. Done.

bug#31840: documentation: Add code of conduct section

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 46 bytes --]

Already fixed as #31841. Closing and merging.

[-- Attachment #2: Type: text/html, Size: 67 bytes --]

bug#31840: documentation: Add code of conduct section

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 49 bytes --]

Sorry about the noise, restoring original state.

[-- Attachment #2: Type: text/html, Size: 70 bytes --]