From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Using the GNU GMP Library for Bignums in Emacs Date: Mon, 09 Jul 2018 16:56:39 -0600 Message-ID: <87o9fgow60.fsf@tromey.com> References: <29f933ac-a6bf-8742-66a7-0a9d6d3e5a88@disroot.org> <83bmecy6fx.fsf@gnu.org> <0d3175d8-d996-651e-b221-71978bde3a65@cs.ucla.edu> <87tvpdnzgy.fsf@tromey.com> <4c2a814f-c254-29e5-39cf-11b5f2e5c9c8@cs.ucla.edu> <87pnzzoeky.fsf@tromey.com> <1150776f-a8fe-86a1-680b-3d1a5d582c6a@cs.ucla.edu> <87lgano9c0.fsf@tromey.com> <87601pq8a7.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531176930 11558 195.159.176.226 (9 Jul 2018 22:55:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 9 Jul 2018 22:55:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: Tom Tromey , Stefan Monnier , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 10 00:55:25 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcf3w-0002mX-IE for ged-emacs-devel@m.gmane.org; Tue, 10 Jul 2018 00:55:21 +0200 Original-Received: from localhost ([::1]:44779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcf63-0001oX-A9 for ged-emacs-devel@m.gmane.org; Mon, 09 Jul 2018 18:57:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcf5L-0001oG-TT for emacs-devel@gnu.org; Mon, 09 Jul 2018 18:56:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcf5G-0001sz-Uy for emacs-devel@gnu.org; Mon, 09 Jul 2018 18:56:47 -0400 Original-Received: from gateway23.websitewelcome.com ([192.185.49.179]:22039) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fcf5G-0001sk-KW for emacs-devel@gnu.org; Mon, 09 Jul 2018 18:56:42 -0400 Original-Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 4C04F80BE for ; Mon, 9 Jul 2018 17:56:41 -0500 (CDT) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cf5FfvSTc79N3cf5FfJOPE; Mon, 09 Jul 2018 17:56:41 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CT9QkiLznnW6v7aN+kauzcXQyr0bL4QdeZ68V7s+Dq0=; b=mae3/QdJ0RykMbW5aJzly6nW8J hCBwG1L1IKwzZk12VH2ZLqYwBxR95VS8DMw8s/+sADPMJuoHzV10bKcpwxTjSV9WtEUpUVjPNiAT8 fg25e96Rrc/WC6YD7bHxxIGsj; Original-Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47022 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fcf5E-002Vvv-UK; Mon, 09 Jul 2018 17:56:41 -0500 X-Attribution: Tom In-Reply-To: (Paul Eggert's message of "Mon, 9 Jul 2018 09:22:18 -0700") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.85.72 X-Source-L: No X-Exim-ID: 1fcf5E-002Vvv-UK X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-85-72.hlrn.qwest.net (bapiya) [75.166.85.72]:47022 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 192.185.49.179 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227187 Archived-At: Paul> With all that in mind, I guess it's OK to use the mpz API after all. I'll make this change shortly. >> one idea would be to put mini-gmp.c into the Emacs source tree, but >> only compile it if the real GMP library is not found. Paul> That sounds like a good idea, given the above. We could also do this Paul> if the installed GMP library is too old for Emacs. I did this, and removed all the non-GMP code paths from my branch. I haven't yet updated the docs or fixed up the tests (they still act as if bignums might not work). There's still one failing test. After those things I guess this is ready to land. How should I submit the patches for review? Tom