From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#32266: Cannot add directory names ending in .el with normal-top-level-add-subdirs-to-load-path Date: Thu, 30 Aug 2018 16:38:54 +0200 Message-ID: <87o9dj3on5.fsf@gmail.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1535640067 31717 195.159.176.226 (30 Aug 2018 14:41:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 30 Aug 2018 14:41:07 +0000 (UTC) Cc: 32266@debbugs.gnu.org To: =?UTF-8?Q?H=C3=A5kon_?= =?UTF-8?Q?H=C3=A6gland?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 30 16:41:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvO87-00086q-0p for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Aug 2018 16:41:03 +0200 Original-Received: from localhost ([::1]:49297 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fvOAD-0006YX-7y for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Aug 2018 10:43:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fvO9X-0005A2-O6 for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 10:42:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fvO79-0001xr-18 for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 10:40:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34268) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fvO78-0001xa-NB for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 10:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fvO78-0001ZU-EF for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 10:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Aug 2018 14:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32266 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32266-submit@debbugs.gnu.org id=B32266.15356399445960 (code B ref 32266); Thu, 30 Aug 2018 14:40:02 +0000 Original-Received: (at 32266) by debbugs.gnu.org; 30 Aug 2018 14:39:04 +0000 Original-Received: from localhost ([127.0.0.1]:39285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvO6B-0001Y2-S9 for submit@debbugs.gnu.org; Thu, 30 Aug 2018 10:39:04 -0400 Original-Received: from mail-wr1-f68.google.com ([209.85.221.68]:39622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvO6B-0001Xa-54 for 32266@debbugs.gnu.org; Thu, 30 Aug 2018 10:39:03 -0400 Original-Received: by mail-wr1-f68.google.com with SMTP id o37-v6so8299769wrf.6 for <32266@debbugs.gnu.org>; Thu, 30 Aug 2018 07:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=LTFy0SshKu82rtXrjomvxMtztkm84CMNkRjlbn+cmQo=; b=GWXYI9y06hfajCRM/WZ0IdXGfyH79FqgAWKmBsuBZCdSSdZ3oyQ9il3Cn1mbDY2/ww z4r4ySb6DGEGNFbbXzi+8SfA/Gux84vk2kJWJVBOpvGtFnRu2RFUWzJtMeNav8VzvNH+ H7vrnQmOBCwOVIdOgQ9a7ksEUOGu1pK9lJ34NgjHtCOkP4J9TG/sXqCJvy+xH0NNZ6Tu 3ezGSw8Q5o79sgMen/oFvhtlxrGjoRdm0N+2RVdR8ahvPnUl3+PfCCr835cmguJGawJq CwlsC+IsXOpeR64x5R+y4mKH+my3qAAbSv372srnspZo0rYM6wjlU+nlIPThxF+CxlLm PQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=LTFy0SshKu82rtXrjomvxMtztkm84CMNkRjlbn+cmQo=; b=sKJJJEOl16CH9qaqUr5eIp8PR2VELFMfqcvPZc0fwQ+p1/IgElnS6v5IfhNj8SXfPu GtV4wMUX8+GYHYXXrxQThhlk8I0VIYy+/5V3IKOXbIafmkfBpM4Vclbz/1nIr9bXsyVu +wTOt7XEbqkA8m6FXF2vPu9+svwdg7wrL/YnC9lx9Mx8zmSvmU7+8ZoxXhLWDh9gT7FH suCZDwwQmRB6bXbigweYG8ZtEx5JbCaUnOUJBk58ds1stZuUr4VzdbLHfogRctpbdrWJ vuo+Xgf2qQzatpJAmi6nlN4t2b0aUR/rXjvZAPE+k20gUlSoZKdDFJPejoRZsmz2CZQ9 2sKw== X-Gm-Message-State: APzg51Czl2UPspl8oCgpJPuJnw4c3TAr9jeO48DPRFtInNU+17lt+ndh 04ETJ46idaKbwIlm+pk0gl9lzjoQ X-Google-Smtp-Source: ANB0VdaCfKfNRr1iRCTgysrV1NbzPwHKgPQHnBTf1/xMJ56qbyWnGjHhzYmECcD0MVZLJnLJCvg4+Q== X-Received: by 2002:adf:94a6:: with SMTP id 35-v6mr7660721wrr.54.1535639937047; Thu, 30 Aug 2018 07:38:57 -0700 (PDT) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id d12-v6sm8519559wru.36.2018.08.30.07.38.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Aug 2018 07:38:56 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: ("=?UTF-8?Q?H=C3=A5kon_?= =?UTF-8?Q?H=C3=A6gland?="'s message of "Wed, 25 Jul 2018 09:12:08 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149881 Archived-At: H=C3=A5kon H=C3=A6gland writes: > Also, when I look at line #474 of the source > > http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/startup.el#n474 > > I see the following predicate for including a directory: > > (not (string-match "\\.elc?\\'" file)) The comment just above says ;; Avoid doing a `stat' when it isn't necessary because ;; that can cause trouble when an NFS server is down. which has been there for a long time. If an NFS server *is* down, then that will manifest itself with other files anyway, so I don=CA=BCt see why we=CA=BCd need special handling here. I propose: diff --git i/lisp/startup.el w/lisp/startup.el index 4eb71abaac..ace4176ac5 100644 --- i/lisp/startup.el +++ w/lisp/startup.el @@ -469,9 +469,6 @@ normal-top-level-add-subdirs-to-load-path (and (string-match "\\`[[:alnum:]]" file) ;; The lower-case variants of RCS and CVS are for DOS/Windows. (not (member file '("RCS" "CVS" "rcs" "cvs"))) - ;; Avoid doing a `stat' when it isn't necessary because - ;; that can cause trouble when an NFS server is down. - (not (string-match "\\.elc?\\'" file)) (file-directory-p file) (let ((expanded (expand-file-name file))) (or (file-exists-p (expand-file-name ".nosearch" expanded))