From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#33428: 27.0.50; edebug-print-{length,level} customization types Date: Mon, 19 Nov 2018 11:32:51 +0100 Message-ID: <87o9alcq7g.fsf@gmx.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1542623534 18698 195.159.176.226 (19 Nov 2018 10:32:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Nov 2018 10:32:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 33428@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 19 11:32:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOgqd-0004he-Jc for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Nov 2018 11:32:07 +0100 Original-Received: from localhost ([::1]:55175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOgsk-0001NG-2x for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Nov 2018 05:34:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOgsZ-0001NB-6P for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:34:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOgsU-0000XR-9O for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:34:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55429) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gOgsU-0000XN-6I for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gOgsU-0007p8-1l for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Nov 2018 10:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.154262358830011 (code B ref -1); Mon, 19 Nov 2018 10:34:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Nov 2018 10:33:08 +0000 Original-Received: from localhost ([127.0.0.1]:59687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOgrc-0007nz-Ik for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:08 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOgra-0007nh-Tx for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOgrU-00008T-Sl for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:01 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:57953) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gOgrU-00008L-QC for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOgrT-00015S-QR for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:33:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOgrO-000056-TS for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:32:59 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:60375) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gOgrO-0008WU-KL for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:32:54 -0500 Original-Received: from rosalinde ([88.74.20.32]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MUDXS-1fxqaM37I2-00QyUW for ; Mon, 19 Nov 2018 11:32:52 +0100 X-Provags-ID: V03:K1:BbXqhQm+qz736FTc0OxFNcoES+kCL58QoTEXAIP5vKeLJ2PNj0V HBfJ0CM4vAGHRsDL+9IiZmQ8MM/TRiJAvkucuvgsIKnwCl0ygyv3gzkmm28bbepqAb5jSCn B+OigNBOqBHyxP2osMX8H5fKhs9gTqb0iqHIP3Mv5mYADoWCjUsBdTx6CCf+aUdo4Id6/oR WDdGemQX2Sn2DfIA3K1vg== X-UI-Out-Filterresults: notjunk:1;V01:K0:HXnuyjk/G88=:mrAK9cTVPSKPY1m++nEjNS 243m1xWzMOh0+rl9ThoDa7O7ixk7SsLxcQvlWgoXP3dpCI6+IZ8HaPTVb6vOOHNqo2A44Svuj iu0t6avY3ilpBEdLLWxcApSRv3pE7y3NbuEUhJKK4eDbO5WbMgXH1JiKLpusZY5KgjZiuKkZG 4aP57cV7XD3TaMa4yeMKmAlwtHJAwy2Ib5Dhjsdf0btK8+cl1hixRIRBgoxXUOKhT2aeYfzlP Kex3Irps9FFAGjhVnT2OIUnryoSBvjaiYwsOstsA9FKVeISFqcHBDI+kKZpdFG7UNcmIaTb6u WLj9XKPY5SCnPYgJkbcYvuI15B/hat3HVYRI3fWVl4hshXtcHu15Ea+mgWSgyQL0illaN6ASP aZA8Rb3eSj8mjJBGSK4UtDa7bxH/GUUSlK2MpqAQv+KVrbKxzr4RJDsnnfCIVVptYHU//7sYo 03Mn1l0OLNnWiG/L7jwKrNjlv1ljoULdOXphuF2/R9bbuA+GMnrI3dwdpJJnZgbqloAaeoT7L /wiEsjkmJvJPgHjbrYqHc8wa1HOBCykIizk3fmhaQ4aqrcSvOCwLo9jWBO1rhEXMVgBkEXcov oEQtRtuabL3ETZ63eRtKhdw/tDwg7WjbTcWHZ9nH3zQ2NhH1XdcpOrBL3rrMRKsdDBUK2e6jg J703eVPDu3aMh7WQRGcfD10csgF1dgty7/cYmsdhndGblyIT2bX9ggzidmq+181IWMk3iiG9c G1RGv17/ZhcT2STpLa8uO07/FuvCTjbB+weqg4v53zlRVcnRoOzOLjw8WwjqQ1qzqqXcGImD X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152527 Archived-At: The doc strings of edebug-print-length and edebug-print-level imply that nil is a valid value and indeed it is. Yet trying to set the value to nil via `M-x customize-option' fails with the error "This field should contain an integer", because nil does not fit the customization type :integer used in the definitions of these user options. It's been like this since they were changed from defvars to defcustoms more than 20 years ago (though "If non-nil" was added to the doc strings only a little less than 10 years ago), so should the fix (below) go into master, or is it on the order of a documentation fix and suitable for the release branch? diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index 15f68a62ac..b50b0383da 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -192,11 +192,11 @@ edebug-continue-kbd-macro (defcustom edebug-print-length 50 "If non-nil, default value of `print-length' for printing results in Edebug." - :type 'integer + :type '(choice integer (const nil)) :group 'edebug) (defcustom edebug-print-level 50 "If non-nil, default value of `print-level' for printing results in Edebug." - :type 'integer + :type '(choice integer (const nil)) :group 'edebug) (defcustom edebug-print-circle t "If non-nil, default value of `print-circle' for printing results in Edebug." In GNU Emacs 27.0.50 (build 13, x86_64-pc-linux-gnu, GTK+ Version 3.22.30) of 2018-11-18 built on rosalinde Repository revision: 5d140800398287c20230dda79162a7c40016d88e Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12001000 System Description: 8.3