From: Stephen Berman <stephen.berman@gmx.net>
To: 33428@debbugs.gnu.org
Subject: bug#33428: 27.0.50; edebug-print-{length,level} customization types
Date: Mon, 19 Nov 2018 11:32:51 +0100 [thread overview]
Message-ID: <87o9alcq7g.fsf@gmx.net> (raw)
The doc strings of edebug-print-length and edebug-print-level imply that
nil is a valid value and indeed it is. Yet trying to set the value to
nil via `M-x customize-option' fails with the error "This field should
contain an integer", because nil does not fit the customization type
:integer used in the definitions of these user options. It's been like
this since they were changed from defvars to defcustoms more than 20
years ago (though "If non-nil" was added to the doc strings only a
little less than 10 years ago), so should the fix (below) go into
master, or is it on the order of a documentation fix and suitable for
the release branch?
diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el
index 15f68a62ac..b50b0383da 100644
--- a/lisp/emacs-lisp/edebug.el
+++ b/lisp/emacs-lisp/edebug.el
@@ -192,11 +192,11 @@ edebug-continue-kbd-macro
(defcustom edebug-print-length 50
"If non-nil, default value of `print-length' for printing results in Edebug."
- :type 'integer
+ :type '(choice integer (const nil))
:group 'edebug)
(defcustom edebug-print-level 50
"If non-nil, default value of `print-level' for printing results in Edebug."
- :type 'integer
+ :type '(choice integer (const nil))
:group 'edebug)
(defcustom edebug-print-circle t
"If non-nil, default value of `print-circle' for printing results in Edebug."
In GNU Emacs 27.0.50 (build 13, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
of 2018-11-18 built on rosalinde
Repository revision: 5d140800398287c20230dda79162a7c40016d88e
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12001000
System Description: 8.3
next reply other threads:[~2018-11-19 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 10:32 Stephen Berman [this message]
2018-11-19 18:37 ` bug#33428: 27.0.50; edebug-print-{length,level} customization types Eli Zaretskii
2018-11-19 22:15 ` Stephen Berman
2018-11-19 22:16 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9alcq7g.fsf@gmx.net \
--to=stephen.berman@gmx.net \
--cc=33428@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.