From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: `help-with-tutorial' (with arg) completion problem Date: Fri, 14 Dec 2018 15:39:46 +0000 Message-ID: <87o99oazi5.fsf@tcd.ie> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1544801938 6141 195.159.176.226 (14 Dec 2018 15:38:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Dec 2018 15:38:58 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: John Paul Wallington Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 14 16:38:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXpYD-0001TS-RC for ged-emacs-devel@m.gmane.org; Fri, 14 Dec 2018 16:38:53 +0100 Original-Received: from localhost ([::1]:34175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXpaK-00074z-4C for ged-emacs-devel@m.gmane.org; Fri, 14 Dec 2018 10:41:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXpZE-00074t-8e for emacs-devel@gnu.org; Fri, 14 Dec 2018 10:39:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXpZD-00013H-H3 for emacs-devel@gnu.org; Fri, 14 Dec 2018 10:39:56 -0500 Original-Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:41544) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXpZD-0000yo-4a for emacs-devel@gnu.org; Fri, 14 Dec 2018 10:39:55 -0500 Original-Received: by mail-ed1-x52d.google.com with SMTP id z28so5280341edi.8 for ; Fri, 14 Dec 2018 07:39:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SiBeP6fmRu7row6NVOpfv4u6AoLGQzvUWEu0pa3cnrU=; b=bRiXhpKueqD/YtpqLVNHYupPWcqin3QRnPozHe3rGMONj9dHaQUVYfNAU35afk/kp9 Vq97anFz5/iK0XUK8vR/3w9WZZyq9EW+ZZiNctFJO/WR2YHCuMbN07RX6JBNc3dfvsfp 1Id2j2VAHjUm8teDLv5ShKkR7ovtDNmRD8kqJAvOB0zSFYJgAs3pP34byCypsmrZpHHP x6QTX9QFMAUXWbmCViveaS05vQfZjLEgqA7AuJhcYvVxdqenQd//vDFtJiH07dFWGSS2 /LeZRr1OmnaCQiu+gQkMlJr7Ugug+68O+D8K2FwI/jN5y8af9cz7zVMhFQkZe8Pwp3vX rGRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=SiBeP6fmRu7row6NVOpfv4u6AoLGQzvUWEu0pa3cnrU=; b=Y9p2laJGggLYy6MGGmiqw0LPpyslI2cFfixxakysXnJMdhUnP9QGXPM5axw5Z2EWaP AMxoqUbX1nZ+RUwoZmX+aI12jTRDEK+SnUYiuNwyt6oOIIoSxR9J56kdrZ7Im3DTRGpA GCOt0azrD+y5TRhSaH2xErDswGzNY6A60+3R9odiC30Ox2ktRtWJ9bxV0gJJBRhrOthw 4v4+6MttmIM03Vq8PPDH/4I1FR4pFoQU7SiyGaIwZZNCYLmJYNLOSP19JCyYaf/OF9p6 1S4flix4mHFFTi5Vbh+5iJGgeXqy4xJEYZj83ivPs5NLrF71Lde5dgyl7u/qnD9Phnr2 8iag== X-Gm-Message-State: AA+aEWbUMDpRll2XT5nPW3tjeZudyktt1zLoVVNZYV0bgi9BQWHSN5KE YmC1FYvMfrS7YfOhY50j+Fi/Li4Xt7M= X-Google-Smtp-Source: AFSGD/Up4cjzZJjPdsRKUkzRcU2fgVwBcU8KAMzRL8mNE7rnhilg+CB9Wh0e6KiBAau8r3flflVyTQ== X-Received: by 2002:a17:906:1353:: with SMTP id x19-v6mr2795377ejb.23.1544801993411; Fri, 14 Dec 2018 07:39:53 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id s3sm1587864eda.69.2018.12.14.07.39.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Dec 2018 07:39:52 -0800 (PST) In-Reply-To: (John Paul Wallington's message of "Wed, 04 Sep 2002 05:24:11 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231838 Archived-At: --=-=-= Content-Type: text/plain John Paul Wallington writes: > Doing C-u C-h t or picking Help => Emacs Tutorial (choose language) > from the menu gives the completion list right away. Why does help-with-tutorial, when invoked with a prefix argument, preemptively pop up the *Completions* buffer? This seems to diverge from most uses of completing-read I've seen, which defer popping up the *Completions* buffer until the user invokes minibuffer-complete or similar. What's more, I noticed this behaviour due to a custom completing-read-function I use which forgoes using the *Completions* buffer, so I find the current default a little intrusive. If it is not crucial for the *Completions* buffer to be displayed immediately, could this minibuffer setup be removed? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=help-with-tutorial.diff diff --git a/lisp/tutorial.el b/lisp/tutorial.el index e3fbdf019c..3e9f5ed35b 100644 --- a/lisp/tutorial.el +++ b/lisp/tutorial.el @@ -764,8 +764,7 @@ help-with-tutorial (message prompt1))) (let* ((lang (cond (arg - (minibuffer-with-setup-hook #'minibuffer-completion-help - (read-language-name 'tutorial "Language: " "English"))) + (read-language-name 'tutorial "Language: " "English")) ((get-language-info current-language-environment 'tutorial) current-language-environment) (t "English"))) --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=--