From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34852: 26.1; seq-intersection ignores nil as element Date: Thu, 14 Mar 2019 17:02:22 +0000 Message-ID: <87o96dcrtt.fsf@tcd.ie> References: <87zhpxabn3.fsf@tcd.ie> <87va0lmwlg.fsf@web.de> <87va0lctwn.fsf@tcd.ie> <87tvg55s8z.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="153757"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Nicolas Petton , "Miguel V. S. Frasson" , 34852@debbugs.gnu.org, Stefan Monnier To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 14 18:06:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4ToB-000dqt-W1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2019 18:06:20 +0100 Original-Received: from localhost ([127.0.0.1]:41766 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4ToA-0002w0-Sf for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2019 13:06:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4To3-0002qh-M9 for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:06:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4Tl2-0003br-7J for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:03:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58649) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4Tl0-0003Zh-7G for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h4Tkz-00041n-UZ for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 17:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34852 X-GNU-PR-Package: emacs Original-Received: via spool by 34852-submit@debbugs.gnu.org id=B34852.155258295115445 (code B ref 34852); Thu, 14 Mar 2019 17:03:01 +0000 Original-Received: (at 34852) by debbugs.gnu.org; 14 Mar 2019 17:02:31 +0000 Original-Received: from localhost ([127.0.0.1]:43960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4TkV-000412-1i for submit@debbugs.gnu.org; Thu, 14 Mar 2019 13:02:31 -0400 Original-Received: from mail-ed1-f47.google.com ([209.85.208.47]:45608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4TkT-00040p-Gt for 34852@debbugs.gnu.org; Thu, 14 Mar 2019 13:02:30 -0400 Original-Received: by mail-ed1-f47.google.com with SMTP id d21so3812011edx.12 for <34852@debbugs.gnu.org>; Thu, 14 Mar 2019 10:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=s+pNf28f5LuXcIYB7/R2TAEmojJVbfvFFpQP6daJ5hg=; b=0ZSfzL+H114108wokCRJ+QhaOt0e6Qu8LyLFjSVuW7hhnptaWO3DcJYhblKXwymGHM DDZqU/dbTjzQdCXEXOORn3XGSSCst7ECUYxKj4t2eL7VYu/Jv4r0ssYj6i1xkP2/EtfP Ny1hvU54oCWOczhfD0nGgnSs2SU57luCdB9cXMTPRBdRUFhhes1qYxuzDpYV8afqVrXc hvPDKXvNFOPcZUD4WV7IQQzN9gn4f0tiwQbzl/u547p0EvzlkygZ6GtjU+j4vJPd8b4p lswny6ZiN9sMmpXJrNijy+hG1o/pqQJmh4CU2uFKS4vbCYOIsOLl8nn0hxpBZWiUntwm o6Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=s+pNf28f5LuXcIYB7/R2TAEmojJVbfvFFpQP6daJ5hg=; b=LFqWjlUKnr+XCBRGVBDGwouZk+gR5mU+9pBsrlJxTIhhmDY0ibZ1BQmogdIvrGRy6t B9sU6yzj0srkaLW1g0brjVSzxk5e9skBkOmRCeH+wpQzF9yl5L/Ige8NKtMg2jwg8aCA 3QKJSVmWAqIG/1BHYN5X24zeaSzePcm/cLSGm005d/YKvMBlAqm2pB/AaHCYRr50VixF GrnxrUlRnT5+jc2Bzch3IbDwDm3FqvRyZT7cvbUTXIMDvX15b1jjASzVBFS92z4pWD0E +jhk9NDTWfneZuxiWYcZgdDuzDG0cSzcxRVHnGA6NpVV+Z3G1oO1hng8TNDJ+NIy492S MQYw== X-Gm-Message-State: APjAAAXf5VwPBfuIqeWymQE0Y2u6KLcONdJsFK+9L9GXEmK039+7MB82 FOxjB0rfuR7tS3qu5t/YgPw3cg== X-Google-Smtp-Source: APXvYqytDpZuQQqNQ7SvVuGFabUjSYY/s6/EcqqqYdOnqVOg7A6pPpn9Xjo/y0/YQQ1eCC+E9hO57w== X-Received: by 2002:aa7:c243:: with SMTP id y3mr5031226edo.283.1552582943637; Thu, 14 Mar 2019 10:02:23 -0700 (PDT) Original-Received: from localhost ([134.226.214.253]) by smtp.gmail.com with ESMTPSA id bs21sm1204573ejb.11.2019.03.14.10.02.22 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 14 Mar 2019 10:02:22 -0700 (PDT) In-Reply-To: <87tvg55s8z.fsf@web.de> (Michael Heerdegen's message of "Thu, 14 Mar 2019 17:35:08 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156342 Archived-At: Michael Heerdegen writes: > "Basil L. Contovounesios" writes: > >> My first patch makes an analogous backward-compatible change using the >> more efficient seq-position in place of seq-some. > > Why is it more efficient? The implementations are more or less > analogue, with the exception that seq-position additionally increments a > counter. Because seq-some involves an additional level of function indirection. This is confirmed by profiling and the attached mini-benchmark, when run as follows: emacs -batch -f batch-byte-compile bench.el emacs -script bench.elc A call to seq-position is also less verbose than one to seq-some for the purpose of finding an element of a sequence. Having said that, the differences are obviously very small. -- Basil