* Re: master ed2b0bd: New faces in xref (bug#23179)
[not found] ` <20190413215422.72DC12044D@vcs0.savannah.gnu.org>
@ 2019-04-14 10:39 ` Robert Pluim
2019-04-14 20:05 ` Juri Linkov
0 siblings, 1 reply; 9+ messages in thread
From: Robert Pluim @ 2019-04-14 10:39 UTC (permalink / raw
To: emacs-devel; +Cc: Juri Linkov
>>>>> On Sat, 13 Apr 2019 17:54:22 -0400 (EDT), juri@jurta.org (Juri Linkov) said:
Juri> branch: master commit
Juri> ed2b0bdfe24551d6a2f0497601f58faa17f24e3d Author: Juri Linkov
Juri> <juri@linkov.net> Commit: Juri Linkov <juri@linkov.net>
Juri> New faces in xref (bug#23179)
I think these new faces warrant at least an entry in NEWS and a
mention in the manual.
Robert
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master ed2b0bd: New faces in xref (bug#23179)
2019-04-14 10:39 ` master ed2b0bd: New faces in xref (bug#23179) Robert Pluim
@ 2019-04-14 20:05 ` Juri Linkov
2019-04-15 8:27 ` Robert Pluim
0 siblings, 1 reply; 9+ messages in thread
From: Juri Linkov @ 2019-04-14 20:05 UTC (permalink / raw
To: emacs-devel
> I think these new faces warrant at least an entry in NEWS and a
> mention in the manual.
I see no other related faces (compilation/grep) mentioned
neither in NEWS nor in the manual.
But I could add new faces to NEWS if Eli decides to do so.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master ed2b0bd: New faces in xref (bug#23179)
2019-04-14 20:05 ` Juri Linkov
@ 2019-04-15 8:27 ` Robert Pluim
2019-04-15 14:34 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Robert Pluim @ 2019-04-15 8:27 UTC (permalink / raw
To: Juri Linkov; +Cc: emacs-devel
>>>>> On Sun, 14 Apr 2019 23:05:38 +0300, Juri Linkov <juri@linkov.net> said:
>> I think these new faces warrant at least an entry in NEWS and a
>> mention in the manual.
Juri> I see no other related faces (compilation/grep) mentioned
Juri> neither in NEWS nor in the manual.
True. Thatʼs arguably a deficiency in the manual.
Juri> But I could add new faces to NEWS if Eli decides to do so.
It would be a useful addition, I think.
Robert
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master ed2b0bd: New faces in xref (bug#23179)
2019-04-15 8:27 ` Robert Pluim
@ 2019-04-15 14:34 ` Eli Zaretskii
2019-04-16 14:02 ` Robert Pluim
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2019-04-15 14:34 UTC (permalink / raw
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Date: Mon, 15 Apr 2019 10:27:45 +0200
> Cc: emacs-devel@gnu.org
>
> Juri> I see no other related faces (compilation/grep) mentioned
> Juri> neither in NEWS nor in the manual.
>
> True. Thatʼs arguably a deficiency in the manual.
I tend to agree. Feel free to document at least the more important
ones ('error', 'warning').
> Juri> But I could add new faces to NEWS if Eli decides to do so.
>
> It would be a useful addition, I think.
I think we do call out new faces in NEWS, so I think these new ones
should be mentioned.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master ed2b0bd: New faces in xref (bug#23179)
2019-04-15 14:34 ` Eli Zaretskii
@ 2019-04-16 14:02 ` Robert Pluim
2019-04-16 15:07 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Robert Pluim @ 2019-04-16 14:02 UTC (permalink / raw
To: Eli Zaretskii; +Cc: emacs-devel
>>>>> On Mon, 15 Apr 2019 17:34:13 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com> Date: Mon, 15 Apr 2019
>> 10:27:45 +0200 Cc: emacs-devel@gnu.org
>>
Juri> I see no other related faces (compilation/grep) mentioned
Juri> neither in NEWS nor in the manual.
>>
>> True. Thatʼs arguably a deficiency in the manual.
Eli> I tend to agree. Feel free to document at least the more
Eli> important ones ('error', 'warning').
grep doesnʼt have any faces that can be customized (at least not for
the output of grep. How about the following for compilation-mode:
diff --git a/doc/emacs/building.texi b/doc/emacs/building.texi
index 78d07b8d39..fa4c7f0e20 100644
--- a/doc/emacs/building.texi
+++ b/doc/emacs/building.texi
@@ -151,6 +151,23 @@ Compilation Mode
the error message in a separate window. The locus is the specific
position in a file where that error occurred.
+@cindex compilation mode faces
+@cindex compilation mode appearance
+@vindex compilation-error-face
+@vindex compilation-error
+@vindex compilation-warning-face
+@vindex compilation-warning
+ The appearance of the @file{*compilation*} buffer can be controlled
+by customizing the faces which are used to highlight parts of the
+@file{*compilation*} buffer, e.g. @code{compilation-error} or
+@code{compilation-warning}, for error and warning messages
+respectively. Note that since those faces inherit from the
+@code{error} and @code{warning} faces, it is also possible to
+customize the parent face directly instead.
+
+ Use @w{@kbd{M-x customize-group RET compilation}} to see the entire
+list of customization variables and faces.
+
@findex compile-goto-error
@vindex compilation-auto-jump-to-first-error
If you change the variable
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: master ed2b0bd: New faces in xref (bug#23179)
2019-04-16 14:02 ` Robert Pluim
@ 2019-04-16 15:07 ` Eli Zaretskii
2019-04-16 15:20 ` Robert Pluim
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2019-04-16 15:07 UTC (permalink / raw
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 16 Apr 2019 16:02:36 +0200
>
> +@cindex compilation mode faces
> +@cindex compilation mode appearance
> +@vindex compilation-error-face
> +@vindex compilation-error
> +@vindex compilation-warning-face
> +@vindex compilation-warning
It is generally not useful to have several index entries which start
with the same text and point to the same place. So I would leave the
odd-numbered entries above and delete the even-numbered.
> + The appearance of the @file{*compilation*} buffer can be controlled
> +by customizing the faces which are used to highlight parts of the
> +@file{*compilation*} buffer, e.g. @code{compilation-error} or
Either "e.g.,", or "e.g.@:", so that TeX doesn't by chance consider
this end of sentence.
Otherwise LGTM, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master ed2b0bd: New faces in xref (bug#23179)
2019-04-16 15:07 ` Eli Zaretskii
@ 2019-04-16 15:20 ` Robert Pluim
2019-04-16 16:01 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Robert Pluim @ 2019-04-16 15:20 UTC (permalink / raw
To: Eli Zaretskii; +Cc: emacs-devel
>>>>> On Tue, 16 Apr 2019 18:07:40 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com> Cc: emacs-devel@gnu.org
>> Date: Tue, 16 Apr 2019 16:02:36 +0200
>>
>> +@cindex compilation mode faces +@cindex compilation mode
>> appearance +@vindex compilation-error-face +@vindex
>> compilation-error +@vindex compilation-warning-face +@vindex
>> compilation-warning
Eli> It is generally not useful to have several index entries
Eli> which start with the same text and point to the same place.
Eli> So I would leave the odd-numbered entries above and delete
Eli> the even-numbered.
I did it slightly differently. The name of the face is
'compilation-error', and 'compilation-error-face' holds the name of
the face to use. customize-face uses the former, so I left that one.
>> + The appearance of the @file{*compilation*} buffer can be
>> controlled +by customizing the faces which are used to
>> highlight parts of the +@file{*compilation*} buffer,
>> e.g. @code{compilation-error} or
Eli> Either "e.g.,", or "e.g.@:", so that TeX doesn't by chance
Eli> consider this end of sentence.
The former seems vastly preferred, so I went with it.
Eli> Otherwise LGTM, thanks.
emacs-26, I imagine.
diff --git a/doc/emacs/building.texi b/doc/emacs/building.texi
index 78d07b8d39..518d157e4e 100644
--- a/doc/emacs/building.texi
+++ b/doc/emacs/building.texi
@@ -151,6 +151,20 @@ Compilation Mode
the error message in a separate window. The locus is the specific
position in a file where that error occurred.
+@cindex compilation mode faces
+@vindex compilation-error
+@vindex compilation-warning
+ The appearance of the @file{*compilation*} buffer can be controlled
+by customizing the faces which are used to highlight parts of the
+@file{*compilation*} buffer, e.g., @code{compilation-error} or
+@code{compilation-warning}, for error and warning messages
+respectively. Note that since those faces inherit from the
+@code{error} and @code{warning} faces, it is also possible to
+customize the parent face directly instead.
+
+ Use @w{@kbd{M-x customize-group RET compilation}} to see the entire
+list of customization variables and faces.
+
@findex compile-goto-error
@vindex compilation-auto-jump-to-first-error
If you change the variable
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: master ed2b0bd: New faces in xref (bug#23179)
2019-04-16 15:20 ` Robert Pluim
@ 2019-04-16 16:01 ` Eli Zaretskii
2019-04-16 16:12 ` Robert Pluim
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2019-04-16 16:01 UTC (permalink / raw
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 16 Apr 2019 17:20:02 +0200
>
> Eli> Otherwise LGTM, thanks.
>
> emacs-26, I imagine.
Right.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master ed2b0bd: New faces in xref (bug#23179)
2019-04-16 16:01 ` Eli Zaretskii
@ 2019-04-16 16:12 ` Robert Pluim
0 siblings, 0 replies; 9+ messages in thread
From: Robert Pluim @ 2019-04-16 16:12 UTC (permalink / raw
To: Eli Zaretskii; +Cc: emacs-devel
>>>>> On Tue, 16 Apr 2019 19:01:55 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com> Cc: emacs-devel@gnu.org
>>
>> emacs-26, I imagine.
Eli> Right.
Done as d0f745f67a
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-04-16 16:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190413215421.15465.98417@vcs0.savannah.gnu.org>
[not found] ` <20190413215422.72DC12044D@vcs0.savannah.gnu.org>
2019-04-14 10:39 ` master ed2b0bd: New faces in xref (bug#23179) Robert Pluim
2019-04-14 20:05 ` Juri Linkov
2019-04-15 8:27 ` Robert Pluim
2019-04-15 14:34 ` Eli Zaretskii
2019-04-16 14:02 ` Robert Pluim
2019-04-16 15:07 ` Eli Zaretskii
2019-04-16 15:20 ` Robert Pluim
2019-04-16 16:01 ` Eli Zaretskii
2019-04-16 16:12 ` Robert Pluim
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.