From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Leah Neukirchen Newsgroups: gmane.emacs.bugs Subject: bug#35273: "Marker does not point anywhere" when reading next article Date: Tue, 16 Apr 2019 16:04:01 +0200 Message-ID: <87o956m4ha.fsf@vuxu.org> References: <875zrgpusw.fsf@vuxu.org> <87lg0czgy1.fsf@tcd.ie> <8736mkgu83.fsf@vuxu.org> <87zhoqxgzn.fsf@gmail.com> <87wojum7vc.fsf@vuxu.org> <87wojuxfdl.fsf@gmail.com> <87sguim6gn.fsf@vuxu.org> <87tveyxdd7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="13358"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: "Basil L. Contovounesios" , 35273@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 16 16:05:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGOi6-0003Aa-V3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Apr 2019 16:05:19 +0200 Original-Received: from localhost ([127.0.0.1]:37496 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGOi5-0003xF-UU for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Apr 2019 10:05:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGOht-0003vu-TK for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2019 10:05:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGOhq-0003Jg-Mf for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2019 10:05:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52369) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGOhq-0003JU-Ey for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2019 10:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hGOhq-0000oE-6a; Tue, 16 Apr 2019 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leah Neukirchen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Tue, 16 Apr 2019 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35273 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 35273-submit@debbugs.gnu.org id=B35273.15554234583040 (code B ref 35273); Tue, 16 Apr 2019 14:05:02 +0000 Original-Received: (at 35273) by debbugs.gnu.org; 16 Apr 2019 14:04:18 +0000 Original-Received: from localhost ([127.0.0.1]:37679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGOh5-0000mt-TE for submit@debbugs.gnu.org; Tue, 16 Apr 2019 10:04:18 -0400 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:53407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGOh1-0000ma-3O for 35273@debbugs.gnu.org; Tue, 16 Apr 2019 10:04:13 -0400 Original-Received: by mail-wm1-f46.google.com with SMTP id q16so25536713wmj.3 for <35273@debbugs.gnu.org>; Tue, 16 Apr 2019 07:04:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Ds3FLv7HS45xzIsiarJlYZw0QyEBG427o8tHerJlaGc=; b=q+9QFInX8l0lmZnOAS5tQ+yt/Y8Lm6PwvqIMOsvlpOyFSay0GkUj7SwV5HG6ICJZXm 6zvK6fgBeJnbM7LSLmfRUFW4UvnMr1pvDUW0BRR5/WjDuM5CgoQcJVb845jfWYp2wl70 mYsDAvpXvkYwjLBnz9gKtI62X8h6s9u+xnZmCog43ggrJm2gOYA3Pnb/0HumfpAbKj4j mXjRkJaKGHSgoGkDq3ZU0ZoBKXiCy55sqtArM/n/AvB8yKCsWMTsEwwwk2JxoGPyRAtF fSHyczuwTojgz1xriOeDzV/DAtb2Wwv9yUYa5IFlnXdm4D5+2OVzAECuRdGWuhg+hJaY /+Ng== X-Gm-Message-State: APjAAAXcaBjA9RXzF0CQxNlzsu4z1JsXZtfGgBwYvZAfjy9Cy7Vj6Bdf uhd0d9mX//ww4hWzZ906hec= X-Google-Smtp-Source: APXvYqx3QYfsVdVmyBYVK3AcLGt2TV34asRER/SVa7hydn52c7tjzRUTV1KhV6Lc+FO8ApIuxD7x/Q== X-Received: by 2002:a1c:6502:: with SMTP id z2mr25508172wmb.119.1555423445276; Tue, 16 Apr 2019 07:04:05 -0700 (PDT) Original-Received: from rhea.home.vuxu.org (host-212-114-138-244.customer.m-online.net. [212.114.138.244]) by smtp.gmail.com with ESMTPSA id n11sm87357182wrt.63.2019.04.16.07.04.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 07:04:04 -0700 (PDT) Original-Received: from localhost (rhea.home.vuxu.org [local]) by rhea.home.vuxu.org (OpenSMTPD) with ESMTPA id afe80a0f; Tue, 16 Apr 2019 14:04:01 +0000 (UTC) In-Reply-To: <87tveyxdd7.fsf@gmail.com> (Noam Postavsky's message of "Tue, 16 Apr 2019 09:56:36 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157716 Archived-At: Noam Postavsky writes: >> (gdb) bt >> #0 marker_position (marker=XIL(0x5555578a47c5)) at marker.c:680 >> #1 0x00005555556fc2dd in mouse_face_overlay_overlaps ( >> overlay=XIL(0x5555578a4825)) at buffer.c:3047 >> #2 0x0000555555606f5f in note_mouse_highlight (f=0x55555610dbf0, x=100, y=9) >> at xdisp.c:31631 > >> (gdb) up >> #1 0x00005555556fc2dd in mouse_face_overlay_overlaps ( >> overlay=XIL(0x5555578a4825)) at buffer.c:3047 >> 3047 ptrdiff_t start = OVERLAY_POSITION (OVERLAY_START (overlay)); >> (gdb) l >> 3042 `mouse-face' property overlapping OVERLAY. */ >> 3043 >> 3044 bool >> 3045 mouse_face_overlay_overlaps (Lisp_Object overlay) >> 3046 { >> 3047 ptrdiff_t start = OVERLAY_POSITION (OVERLAY_START (overlay)); >> 3048 ptrdiff_t end = OVERLAY_POSITION (OVERLAY_END (overlay)); > > Oh right, OVERLAY_POSITION calls marker_position. I think the patch > below should paper over the problem, but I'm not sure if it's the right > thing. > > --- i/src/buffer.c > +++ w/src/buffer.c > @@ -3044,8 +3044,13 @@ overlays_in (EMACS_INT beg, EMACS_INT end, bool extend, > bool > mouse_face_overlay_overlaps (Lisp_Object overlay) > { > - ptrdiff_t start = OVERLAY_POSITION (OVERLAY_START (overlay)); > - ptrdiff_t end = OVERLAY_POSITION (OVERLAY_END (overlay)); > + Lisp_Object start_pos = Fmarker_position (OVERLAY_START (overlay)); > + Lisp_Object end_pos = Fmarker_position (OVERLAY_END (overlay)); > + if (!(INTEGERP (start_pos) && INTEGERP (end_pos))) > + return false; > + intmax_t start, end; > + integer_to_intmax (start_pos, &start); > + integer_to_intmax (end_pos, &end); > ptrdiff_t n, i, size; > Lisp_Object *v, tem; > Lisp_Object vbuf[10]; > I cannot reproduce the error anymore after applying the patch. Thanks, -- Leah Neukirchen http://leah.zone