From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Renaming non-X x_* identifiers Date: Fri, 26 Apr 2019 21:46:34 -0600 Message-ID: <87o94snm91.fsf@gmail.com> References: <87wokp4okn.fsf@gmail.com> <83ef6xpo6b.fsf@gnu.org> <0f4be9a6-6e09-f55d-9f58-2a15aef264cd@cs.ucla.edu> <837ecpplw8.fsf@gnu.org> <871s2w510a.fsf@gmail.com> <922F9B91-2E9E-45F6-BB96-66CAE5E9FB81@gnu.org> <87k1goqpnn.fsf@gmail.com> <83imw8nspc.fsf@gnu.org> <87ftrcqg5j.fsf@gmail.com> <83bm20nm62.fsf@gnu.org> <87d0men4jx.fsf@gmail.com> <83o95sisk7.fsf@gnu.org> <87mulcnui4.fsf@gmail.com> <83bm1si7lf.fsf@gnu.org> <87ef6ont03.fsf@gmail.com> <83a7hci44l.fsf@gnu.org> <87a7hcndtc.fsf@gmail.com> <831s2nhza8.fsf@gnu.org> <87d0lpvq6n.fsf_-_@gmail.com> <875zr0z00x.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="201976"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 27 05:46:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hKEIa-000qNi-RM for ged-emacs-devel@m.gmane.org; Sat, 27 Apr 2019 05:46:49 +0200 Original-Received: from localhost ([127.0.0.1]:55098 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKEIX-0000dP-G7 for ged-emacs-devel@m.gmane.org; Fri, 26 Apr 2019 23:46:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKEIR-0000cx-74 for emacs-devel@gnu.org; Fri, 26 Apr 2019 23:46:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKEIQ-0003l9-7S for emacs-devel@gnu.org; Fri, 26 Apr 2019 23:46:39 -0400 Original-Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:46879) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hKEIQ-0003j6-22; Fri, 26 Apr 2019 23:46:38 -0400 Original-Received: by mail-pf1-x42d.google.com with SMTP id j11so2595831pff.13; Fri, 26 Apr 2019 20:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=VZjG2ogglivMsFdOEWkZqehhv+pQfJH+JMCzwbelcUE=; b=c5TMX8Fh6LE5zEVpvyysb7W8pMmSXRwxO0HGZp/W6Cw8pM6xkvxOrPW7+P9RUavWBj AcF8Mx15jzoc4TaKDybdKN2zdB2eft/3WeMM1vIm0fkVbja0uwAosmsIvIhjpjyASjxp eybZgu+qwIQp3syS8LMObKA9CtnGw5CtgY8fhtgkH7KI5rw6ytg4oBoxlmYOVHQfqQBz /mC8zSqkgVMuSLvl7Hg+WDk/JJUnBx/TGLPiBCk8GAqDL687vNXBXJNAq8wovDFQ5JXF 05Qa34gDysUrcIf4WqEazi2irObTyN07MXKyfvAuAgOD/Ungs6sI8VZRceJGti5oKUdo VdVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=VZjG2ogglivMsFdOEWkZqehhv+pQfJH+JMCzwbelcUE=; b=Kcky988m8qlT/0jwCJmW3QBvrDLeqOmbLzr/aj8KJsz0R2YkNNsLKh1Mkbi6yBvgP7 PKyp2pNg2u6XNM0/nZuxiJoIu/nAUxF992VpNtc0deWFgbIxNuE3vZ4QAAtckOGlorsz JdlISt/8uVA7WnTSzXtc3yHNUsCWW6cEZDmdXDzUc6qFsP9sTB1d5/1lX75PbFifz7Eh C1m9nkmH5AN9e8K9cUWoR1bogJ6MerxO4TSfI+yP2Dji5FRSa0X1CXkA+1R2iGmqhZYn 8tN/zqMtKX0GWfPnp8pxRU+Y9Ah4gmovPZ561Sedwfjaj4d1ZkQHpKXzCdJOqq8RcSWr kzaA== X-Gm-Message-State: APjAAAXZTJPK7nBdyZpKdZfSwA7aJOXF74GVmGgiSH/kug4w0VWonky1 RbIbNhptebgBiTJt5YHgakG6FeaN X-Google-Smtp-Source: APXvYqxdQ3IienVS/WzyXf4+T0/R727WU+hEYRjputExhonJuzAqP8Eegvq2z8djfk3yeg+fX3MShw== X-Received: by 2002:a62:5445:: with SMTP id i66mr21007972pfb.250.1556336796587; Fri, 26 Apr 2019 20:46:36 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id h20sm68416351pfj.40.2019.04.26.20.46.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 20:46:35 -0700 (PDT) In-Reply-To: <875zr0z00x.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 27 Apr 2019 02:53:34 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235979 Archived-At: "Basil L. Contovounesios" writes: >> diff --git a/src/xdisp.c b/src/xdisp.c >> index ae4c405b8d..11667d2735 100644 >> --- a/src/xdisp.c >> +++ b/src/xdisp.c >> @@ -11592,9 +11592,8 @@ clear_garbaged_frames (void) >> else >> clear_current_matrices (f); >> >> -#if defined (HAVE_WINDOW_SYSTEM) && !defined (HAVE_NS) >> - x_clear_under_internal_border (f); >> -#endif /* HAVE_WINDOW_SYSTEM && !HAVE_NS */ >> + if (FRAME_RIF (f)->clear_under_internal_border) >> + FRAME_RIF (f)->clear_under_internal_border (f); >> >> fset_redisplay (f); >> f->garbaged = false; > > This causes a segfault in 'emacs -nw' and emacsclient because > FRAME_RIF (f) is NULL in tty frames such as the initial daemon frame. Sorry about the trouble. Somehow I didn't test using -nw with a HAVE_WINDOW_SYSTEM build. It should be fixed now. > Is x_clear_under_internal_border not supposed to be run in tty frames? Previously it did, but each implementation of that procedure was a no-op for tty frames. The issue is that FRAME_RIF procedures shouldn't be called for tty frames; I didn't realize that FRAME_RIF was NULL for tty frames instead of a blank struct. I wonder if that should be changed to avoid this in the future?