Eli Zaretskii writes: >> From: Alex Gramiak >> Cc: emacs-devel@gnu.org >> Date: Thu, 09 May 2019 11:16:06 -0600 >> >> > There's one more instance of FRAME_X_DISPLAY in xdisp.c which was >> > left, and it will fail compilation on non-X platforms. >> > >> > Otherwise, this LGTM, thanks. >> >> I only see one such instance, and it's surrounded by: >> >> #if false && defined HAVE_X_WINDOWS >> >> So it should be good, no? > > That one, yes. But there's one more, and it isn't conditioned by > HAVE_X_WINDOWS. Are you maybe looking on a wrong branch? I'm on > master. You mean the one in init_glyph_string, right? That was removed in my first patch, which I've attached again below: