Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow

["Basil L. Contovounesios" <contovob@tcd.ie>]

Andy Moreton <andrewjmoreton@gmail.com> writes:

> Building commit 65d45def8d71e50d111adf1141011a5d30a27447 still fails on
> MSYS2 (Windows), and adds warnings:
>
> C:/emacs/git/emacs/master/lib/canonicalize-lgpl.c:51:21: warning: no previous
> prototype for 'realpath' [-Wmissing-prototypes]
>    51 | # define __realpath realpath
>       |                     ^~~~~~~~
> C:/emacs/git/emacs/master/lib/canonicalize-lgpl.c:117:1: note: in expansion of macro '__realpath'
>   117 | __realpath (const char *name, char *resolved)
>       | ^~~~~~~~~~
> C:/emacs/git/emacs/master/lib/canonicalize-lgpl.c:50:35: warning: no previous
> prototype for 'canonicalize_file_name' [-Wmissing-prototypes]
>    50 | # define __canonicalize_file_name canonicalize_file_name
>       |                                   ^~~~~~~~~~~~~~~~~~~~~~
> C:/emacs/git/emacs/master/lib/canonicalize-lgpl.c:416:1: note: in expansion of
> macro '__canonicalize_file_name'
>   416 | __canonicalize_file_name (const char *name)
>       | ^~~~~~~~~~~~~~~~~~~~~~~~
>
> [...]
>
> C:/emacs/git/emacs/master/src/emacs.c: In function 'load_pdump':
> C:/emacs/git/emacs/master/src/emacs.c:851:22: warning: implicit declaration of
> function 'realpath' [-Wimplicit-function-declaration]
>   851 |       real_exename = realpath (exename, NULL);
>       |                      ^~~~~~~~
> C:/emacs/git/emacs/master/src/emacs.c:851:22: warning: nested extern declaration
> of 'realpath' [-Wnested-externs]
> C:/emacs/git/emacs/master/src/emacs.c:851:20: warning: assignment to 'char *'
> from 'int' makes pointer from integer without a cast [-Wint-conversion]
>   851 |       real_exename = realpath (exename, NULL);
>       |                    ^
> C:/emacs/git/emacs/master/src/emacs.c:923:7: error: 'argv0_len' undeclared
> (first use in this function)
>   923 |       argv0_len = strlen (argv0_base);
>       |       ^~~~~~~~~
> C:/emacs/git/emacs/master/src/emacs.c:923:7: note: each undeclared identifier is
> reported only once for each function it appears in
> make[1]: *** [Makefile:402: emacs.o] Error 1

See also:
https://lists.gnu.org/archive/html/emacs-devel/2019-06/msg00898.html

-- 
Basil