From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format Date: Tue, 23 Jul 2019 13:31:59 +0200 Message-ID: <87o91l0yxc.fsf@mouse.gnus.org> References: <877e8b477a.fsf@mouse.gnus.org> <877e8a2qzp.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="107589"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 27453@debbugs.gnu.org To: Rohan Hart Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 23 13:33:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpt2Z-000Rup-VS for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jul 2019 13:33:08 +0200 Original-Received: from localhost ([::1]:41354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpt2Y-0005EE-Jj for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jul 2019 07:33:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54830) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpt2V-0005Cl-Ma for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 07:33:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpt2U-0000rT-Gd for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 07:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpt2U-0000qt-Aa for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 07:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hpt2U-00064F-59 for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 07:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2019 11:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27453 X-GNU-PR-Package: emacs Original-Received: via spool by 27453-submit@debbugs.gnu.org id=B27453.156388152421960 (code B ref 27453); Tue, 23 Jul 2019 11:33:02 +0000 Original-Received: (at 27453) by debbugs.gnu.org; 23 Jul 2019 11:32:04 +0000 Original-Received: from localhost ([127.0.0.1]:34116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpt1Y-0005hs-Hv for submit@debbugs.gnu.org; Tue, 23 Jul 2019 07:32:04 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:37784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpt1X-0005gX-7V for 27453@debbugs.gnu.org; Tue, 23 Jul 2019 07:32:03 -0400 Original-Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpt1T-000876-Lz; Tue, 23 Jul 2019 13:32:02 +0200 In-Reply-To: (Rohan Hart's message of "Tue, 23 Jul 2019 08:42:40 +1200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163627 Archived-At: Rohan Hart writes: > Well sure, I only raised this as log-view states: > > ;; Currently supports the format output by: > ;; SCCS, RCS, CVS, Subversion, DaRCS, and Mercurial. > > And later mentions code related to both darcsum and vc-darcs. Then perhaps it does make sense to add the regexp to log-view-message-re after all. The current definition is: (defvar log-view-message-re (concat "^\\(?:revision \\(?1:[.0-9]+\\)\\(?:\t.*\\)?" ; RCS and CVS. "\\|r\\(?1:[0-9]+\\) | .* | .*" ; Subversion. "\\|D \\(?1:[.0-9]+\\) .*" ; SCCS. ;; Darcs doesn't have revision names. VC-darcs uses patch names ;; instead. Darcs patch names are hashcodes, which do not appear ;; in the log output :-(, but darcs accepts any prefix of the log ;; message as a patch name, so we match the first line of the log ;; message. ;; First loosely match the date format. (concat "\\|[^ \n].*[^0-9\n][0-9][0-9]:[0-9][0-9][^0-9\n].*[^ \n]" ;;Email of user and finally Msg, used as revision name. " .*@.*\n\\(?: \\* \\(?1:.*\\)\\)?") "\\)$") Is VC-darcs something else than darcs? Or is that an Emacs package? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no