From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 5aa6a15: Treat the "Link" link in gnus-summary-browse-urls specially Date: Wed, 24 Jul 2019 14:54:14 +0200 Message-ID: <87o91jzj7t.fsf@mouse.gnus.org> References: <20190716212507.31541.72823@vcs0.savannah.gnu.org> <20190716212509.24A6E20BE2@vcs0.savannah.gnu.org> <87imrsjf9a.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="235591"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: sds@gnu.org, emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 24 14:54:29 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqGmo-000z89-Az for ged-emacs-devel@m.gmane.org; Wed, 24 Jul 2019 14:54:26 +0200 Original-Received: from localhost ([::1]:51368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqGmn-0002yb-7v for ged-emacs-devel@m.gmane.org; Wed, 24 Jul 2019 08:54:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56969) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqGml-0002yR-3w for emacs-devel@gnu.org; Wed, 24 Jul 2019 08:54:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqGmk-0005Wg-09 for emacs-devel@gnu.org; Wed, 24 Jul 2019 08:54:23 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:49768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hqGmh-0005VQ-VX; Wed, 24 Jul 2019 08:54:20 -0400 Original-Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqGmd-0002TK-IX; Wed, 24 Jul 2019 14:54:17 +0200 In-Reply-To: <87imrsjf9a.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 23 Jul 2019 20:14:09 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238867 Archived-At: Eric Abrahamsen writes: > Could we put this back the way it was? I don't know why "Link" as link > text should be treated specially -- now if any of the urls are called > "Link" I have to delete the text. At least make it the default argument > to `completing-read', not the inital input. But I don't see why this > text is treated specially. As a DWIM thing, it may make sense? But, yes, it shouldn't be the initial input. As a default it's nice, though. But then perhaps it should say (in the prompt) what the default is, which will make the default very long... Other usability nits in that function: It uses widget-move, which will echo the contents, which is very annoying, because that means that it flashes a large number of things in the echo area. And the prefix argument to `w' should probably be to act the same as in eww; i.e., use `shr-external-browser' for the browser. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no