From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: sds@gnu.org, emacs-devel@gnu.org
Subject: Re: master 5aa6a15: Treat the "Link" link in gnus-summary-browse-urls specially
Date: Wed, 24 Jul 2019 14:54:14 +0200 [thread overview]
Message-ID: <87o91jzj7t.fsf@mouse.gnus.org> (raw)
In-Reply-To: <87imrsjf9a.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 23 Jul 2019 20:14:09 -0700")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Could we put this back the way it was? I don't know why "Link" as link
> text should be treated specially -- now if any of the urls are called
> "Link" I have to delete the text. At least make it the default argument
> to `completing-read', not the inital input. But I don't see why this
> text is treated specially.
As a DWIM thing, it may make sense? But, yes, it shouldn't be the
initial input. As a default it's nice, though. But then perhaps it
should say (in the prompt) what the default is, which will make the
default very long...
Other usability nits in that function: It uses widget-move, which will
echo the contents, which is very annoying, because that means that it
flashes a large number of things in the echo area.
And the prefix argument to `w' should probably be to act the same as in
eww; i.e., use `shr-external-browser' for the browser.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-07-24 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190716212507.31541.72823@vcs0.savannah.gnu.org>
[not found] ` <20190716212509.24A6E20BE2@vcs0.savannah.gnu.org>
2019-07-24 3:14 ` master 5aa6a15: Treat the "Link" link in gnus-summary-browse-urls specially Eric Abrahamsen
2019-07-24 12:54 ` Lars Ingebrigtsen [this message]
2019-07-24 16:01 ` Sam Steingold
2019-07-24 15:56 ` Sam Steingold
2019-07-24 17:13 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o91jzj7t.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=sds@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.