From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 66db7b2 1/2: Always include the number of unexpected results here too Date: Sat, 27 Jul 2019 12:58:18 +0100 Message-ID: <87o91fvgdh.fsf@tcd.ie> References: <20190726075902.16162.83489@vcs0.savannah.gnu.org> <20190726075904.0A44C20C06@vcs0.savannah.gnu.org> <87sgqs4ye0.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="177180"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 27 13:58:29 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrLLI-000jti-JY for ged-emacs-devel@m.gmane.org; Sat, 27 Jul 2019 13:58:28 +0200 Original-Received: from localhost ([::1]:45134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrLLG-00089p-Up for ged-emacs-devel@m.gmane.org; Sat, 27 Jul 2019 07:58:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41786) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrLLE-00088U-E3 for emacs-devel@gnu.org; Sat, 27 Jul 2019 07:58:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrLLD-0003ME-5Y for emacs-devel@gnu.org; Sat, 27 Jul 2019 07:58:24 -0400 Original-Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:35637) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrLLC-0003K3-A1 for emacs-devel@gnu.org; Sat, 27 Jul 2019 07:58:22 -0400 Original-Received: by mail-wr1-x444.google.com with SMTP id y4so57016374wrm.2 for ; Sat, 27 Jul 2019 04:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=aCPr5NxgTaNcRAEywJ5ysjbYPS2RpdiL1e4p/r/7/1E=; b=TJy0MtpXM56BWQT4vw5gQhUqJUkyM5m4208HLs8lFfKm2fzDmskPBuaVHWcO0xpkII fVhLw8ixAy07KxQ/uDxuBUZxCBJ6n3llN02h/uAFoG1g7f/VVxO2D5bPEx7f3JFa567N 7psc3k7W9gL4Xc1Zp8sLO13cevEeTgP67wcGuYiGzz2hJndHeZgOfs3L/zacwSBqHtEG 2esov8arbliQA8sgnMImvs3cLhnbR4eGoVUhlk9tlVlt4OMnuEcpAxkkr7qxw9Wok66t eySmef4VROBx8dBtD2T3+03RAdGQ1lxg+jvelSiOogl6HLGTLI73PyUAVdMtNIuBSAQ3 mglg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=aCPr5NxgTaNcRAEywJ5ysjbYPS2RpdiL1e4p/r/7/1E=; b=a3X5pG8XjMyLbpLX8cAp0UQliFqaLEataK+Diuf4ZzhhBPouo/hl5n9TTYj0WWrYfE mZcWLSbtutIgFF4kPbdu5hKconSBxAfIG5ZouQ1JQ4frmoSEmILJe2kedN4sAD8QNxKC BzyI0bJeRiDscSGX3TkLtvsQ7svtdHwQ2lRQfJd00J86yBFVoxEdflFnpya5X9SZm7Wi mGosXP5CbVabdoLMwdWSU1Y4bqpP8XaylBGyrAHCJOJ9XrVLJjPydlXFpmiP92Me6hXJ m/fBqey7sF17e7Oa0zMyfwPCk44KHog48KrZKkwXfQL8jHp6ml4pkiat6+u1LIBirCoY c4KA== X-Gm-Message-State: APjAAAW12NNFU0leKU83H+umAe7E0N8hjVud3tJTRCkEGA26vstB88uF CbRjRs0vUY7uA6G7bNZNtMOH3w== X-Google-Smtp-Source: APXvYqx4+l/zRR3jS72NLIGvstZWbrscB8MFuZGsZp9ZyZOpJElPJpWUzMpDIGWgUr+303C2XaTo4Q== X-Received: by 2002:a5d:540e:: with SMTP id g14mr23850661wrv.346.1564228700989; Sat, 27 Jul 2019 04:58:20 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id a81sm57135138wmh.3.2019.07.27.04.58.20 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 27 Jul 2019 04:58:20 -0700 (PDT) In-Reply-To: (Lars Ingebrigtsen's message of "Sat, 27 Jul 2019 12:07:21 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238946 Archived-At: Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> larsi@gnus.org (Lars Ingebrigtsen) writes: >> >> Should this be updated as follows? >> >> diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el >> index 272fd4aec2..c659e4f3fc 100644 >> --- a/lisp/emacs-lisp/ert.el > > Looks like Paul made a similar change to fix this already... Indeed (thanks Paul), but what about this question: >> What about ert-run-tests-interactively and >> ert--results-format-expected-unexpected? Do these need to be updated for consistency with the other reporting functions? Thanks, -- Basil