From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#17779: 24.4.50; (elisp) `Using Interactive' Date: Sun, 04 Aug 2019 14:41:55 +0200 Message-ID: <87o9159k6k.fsf@mouse.gnus.org> References: <79a25ee9-e53e-494f-b7e3-ebd2e2eebafa@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="194704"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 17779@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 04 15:15:39 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huGMN-000oY2-LE for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 15:15:39 +0200 Original-Received: from localhost ([::1]:44474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huGMM-0003qX-MD for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 09:15:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47950) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huGLo-00033h-FR for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huGLn-000767-6Y for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51985) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1huGLn-000763-3c for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1huGLm-0000LE-Sk for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2019 13:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17779 X-GNU-PR-Package: emacs Original-Received: via spool by 17779-submit@debbugs.gnu.org id=B17779.15649244741232 (code B ref 17779); Sun, 04 Aug 2019 13:15:02 +0000 Original-Received: (at 17779) by debbugs.gnu.org; 4 Aug 2019 13:14:34 +0000 Original-Received: from localhost ([127.0.0.1]:60800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huGLK-0000Ji-Be for submit@debbugs.gnu.org; Sun, 04 Aug 2019 09:14:34 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:37358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huGLI-0000Hz-Ir for 17779@debbugs.gnu.org; Sun, 04 Aug 2019 09:14:32 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huFpj-0007OF-VD; Sun, 04 Aug 2019 14:41:58 +0200 In-Reply-To: <79a25ee9-e53e-494f-b7e3-ebd2e2eebafa@default> (Drew Adams's message of "Sat, 14 Jun 2014 08:50:37 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164568 Archived-At: Drew Adams writes: > I wonder about the bullet "It may be a Lisp expression that is not a > string...". > > 1. The text for this does two things, which should perhaps be separated: > (a) it describes the general nature and use of such an expression, and > (b) it goes down a rabbit hole to talk about one particular gotcha. > > Combining these in the same bullet, which is supposed to present the > non-string Lisp sexp case, just confuses things - that's my guess. > > 2. Wrt that gotcha: Really? I'm probably missing something here, since > this text has been in the manual for a long time. But here's my take on > this gotcha. What am I missing? (I've included the .texi below for reference.) Yes, I think you're right -- the text starting with "Providing point or the mark" until the end of the example seems like very confusing text to include in an introduction to `interactive'. The failure modes (if you can call it that) are hyper-specific to a very obscure case, and (as Drew says) what the user should do here depends on what the user wants. So I think that bit should just be removed from the manual. Any objections? ---- @item It may be a Lisp expression that is not a string; then it should be a form that is evaluated to get a list of arguments to pass to the command. Usually this form will call various functions to read input from the user, most often through the minibuffer (@pxref{Minibuffers}) or directly from the keyboard (@pxref{Reading Input}). Providing point or the mark as an argument value is also common, but if you do this @emph{and} read input (whether using the minibuffer or not), be sure to get the integer values of point or the mark after reading. The current buffer may be receiving subprocess output; if subprocess output arrives while the command is waiting for input, it could relocate point and the mark. Here's an example of what @emph{not} to do: @smallexample (interactive (list (region-beginning) (region-end) (read-string "Foo: " nil 'my-history))) @end smallexample @noindent Here's how to avoid the problem, by examining point and the mark after reading the keyboard input: @smallexample (interactive (let ((string (read-string "Foo: " nil 'my-history))) (list (region-beginning) (region-end) string))) @end smallexample ---- -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no