bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings

bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings

[Alex Branham]

Hi -

The commands gnus-1 and gnus have identical docstrings. gnus-1 should
probably specify how it differs from just M-x gnus (or be
noninterative).

Thanks,
Alex

bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings

[Eric Abrahamsen]

Alex Branham <alex.branham@gmail.com> writes:

> Hi -
>
> The commands gnus-1 and gnus have identical docstrings. gnus-1 should
> probably specify how it differs from just M-x gnus (or be
> noninterative).

I'm inclined to think that gnus-1 (and gnus-no-server-1) shouldn't be
interactive. I can't see any point to it -- the *-1 variants live in
gnus-start.el and are not autoloaded. It seems like Gnus' entry points
should be interactive and autoloaded, and what happens after that is
internals.

bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings

[Alex Branham]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

tags 37022 + patch
quit

On Wed 14 Aug 2019 at 12:55, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:

> Alex Branham <alex.branham@gmail.com> writes:
>
>> Hi -
>>
>> The commands gnus-1 and gnus have identical docstrings. gnus-1 should
>> probably specify how it differs from just M-x gnus (or be
>> noninterative).
>
> I'm inclined to think that gnus-1 (and gnus-no-server-1) shouldn't be
> interactive. I can't see any point to it -- the *-1 variants live in
> gnus-start.el and are not autoloaded. It seems like Gnus' entry points
> should be interactive and autoloaded, and what happens after that is
> internals.

Here's a patch that makes them noninteractive.

Alex


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-gnus-gnus-start.el-gnus-1-gnus-no-server-1-Make.patch --]
[-- Type: text/x-patch, Size: 1198 bytes --]

From 2c2411d94618d8c719c2583fe7ed1c19d02cbae9 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 23 Aug 2019 10:51:48 -0500
Subject: [PATCH] * lisp/gnus/gnus-start.el (gnus-1, gnus-no-server-1): Make
 noninteractive

bug#37022
---
 lisp/gnus/gnus-start.el | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el
index 930d522c41..e8775c6667 100644
--- a/lisp/gnus/gnus-start.el
+++ b/lisp/gnus/gnus-start.el
@@ -738,7 +738,6 @@ gnus-no-server-1
 and not a positive number, Gnus will prompt the user for the name
 of an NNTP server to use.  As opposed to \\[gnus], this command
 will not connect to the local server."
-  (interactive "P")
   (let ((val (or arg (1- gnus-level-default-subscribed))))
     (gnus val t slave)
     (make-local-variable 'gnus-group-use-permanent-levels)
@@ -749,8 +748,6 @@ gnus-1
 If ARG is non-nil and a positive number, Gnus will use that as the
 startup level.  If ARG is non-nil and not a positive number, Gnus will
 prompt the user for the name of an NNTP server to use."
-  (interactive "P")
-
   (if (gnus-alive-p)
       (progn
 	(gnus-run-hooks 'gnus-before-resume-hook)
-- 
2.22.0

bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings

[Lars Ingebrigtsen]

Alex Branham <alex.branham@gmail.com> writes:

> Here's a patch that makes them noninteractive.

Thanks; applied to the trunk.

I don't know why those functions were ever interactive.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no