From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Tabs Date: Sun, 01 Sep 2019 22:57:24 +0300 Organization: LINKOV.NET Message-ID: <87o903dc2j.fsf@mail.linkov.net> References: <87a7bpysm8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="50112"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 01 22:18:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i4WJ2-000CsL-U0 for ged-emacs-devel@m.gmane.org; Sun, 01 Sep 2019 22:18:37 +0200 Original-Received: from localhost ([::1]:60094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4WJ1-0007Da-OF for ged-emacs-devel@m.gmane.org; Sun, 01 Sep 2019 16:18:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55707) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4WF9-0004e4-G2 for emacs-devel@gnu.org; Sun, 01 Sep 2019 16:14:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4WF8-0006vT-Ic for emacs-devel@gnu.org; Sun, 01 Sep 2019 16:14:35 -0400 Original-Received: from blue.elm.relay.mailchannels.net ([23.83.212.20]:38314) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i4WF6-0006tl-K0 for emacs-devel@gnu.org; Sun, 01 Sep 2019 16:14:34 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A93B05E29EE; Sun, 1 Sep 2019 20:14:30 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a51.g.dreamhost.com (100-96-85-60.trex.outbound.svc.cluster.local [100.96.85.60]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 36E115E2BC0; Sun, 1 Sep 2019 20:14:30 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a51.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Sun, 01 Sep 2019 20:14:30 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Power-Tank: 257cb22e2f2557f1_1567368870501_2679285237 X-MC-Loop-Signature: 1567368870501:2921503009 X-MC-Ingress-Time: 1567368870500 Original-Received: from pdx1-sub0-mail-a51.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a51.g.dreamhost.com (Postfix) with ESMTP id 99FDD83BF2; Sun, 1 Sep 2019 13:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=X75flmYWrmnigGVrmytJdoI31Wg=; b= LTpCnKPTdGR3ZoXa4Hi6ekE/ddr/bmz1+wWK1Z+PQWmy42LR8fSKRZQ8pZohFmk8 wc38wzZh0cJkeuAH4JpdluCIBuJvQ20Cy4soCICUqVHizxfZLj/GyXHepGvfFo8D pEYfyH6F4IxaGavufQiXRGzQF67EvyT8HtTlfhLanN0= Original-Received: from mail.jurta.org (m91-129-108-240.cust.tele2.ee [91.129.108.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a51.g.dreamhost.com (Postfix) with ESMTPSA id 2BE5A83BE5; Sun, 1 Sep 2019 13:14:26 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a51 In-Reply-To: (martin rudalics's message of "Sun, 1 Sep 2019 10:12:41 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudeikedgudegvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtkedrvdegtdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdekrddvgedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtoheprhhuuggrlhhitghssehgmhigrdgrthenucevlhhushhtvghrufhiiigvpedt X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 23.83.212.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239761 Archived-At: >> Finally > > ... some ten years after you started ... Thanks to your help, 3 months ago I have been able finally to understand how persistence of window configurations/states should be implemented. Also such implementation would not be possible earlier before other improvements including window states and framesets were implemented. So it seems now is the right time :) >> now a complete implementation is available for these >> etc/TODO tasks: > > To make your branch build on Windows you need to install the attached > patch at least (blindly copied from its X counterparts). Therafter, > Emacs builds and comes up normally. Thanks, I pushed your patch to the branch. I hope it would be possible to do refactoring on top of your patch to avoid duplicating GUI code like Eli asked. > After clicking on the Show/Hide Tab Bar menu entry, I see > > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) > toggle-tab-bar-mode-from-frame(toggle) > funcall-interactively(toggle-tab-bar-mode-from-frame toggle) > call-interactively(toggle-tab-bar-mode-from-frame nil nil) > command-execute(toggle-tab-bar-mode-from-frame) There is no such problem on X, so I guess it's Windows-specific? > When clicking on a tab in a tab lines entry I get > > is undefined > is undefined This looks like Windows-specific too. > I didn't look into the details of how these are implemented. > > Please also provide a simple recipe for testing your branch. The simplest recipe is this: 0. emacs -Q 1. M-x tab-bar-mode RET 2. Click on the plus sign to create a new tab 3. Click on the previous tab 4. Click on the close icon 0. emacs -Q 1. M-x global-tab-line-mode 2. Click on the plus sign and select a buffer to create a new tab 3. Click on the previous tab 4. Click on the close icon This covers the basic parts of the user interface.