From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Date: Sun, 29 Sep 2019 14:09:06 +0200 Message-ID: <87o8z3mhi5.fsf@gnus.org> References: <87o9m14y0x.fsf@gmail.com> <1517054395.9954.0@smtp.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="184160"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: stefan@merten-home.de, 30063@debbugs.gnu.org To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 29 14:10:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEY1l-000lmL-EA for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Sep 2019 14:10:13 +0200 Original-Received: from localhost ([::1]:38882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEY1j-0001Ce-4K for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Sep 2019 08:10:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51870) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEY1b-0001CH-AQ for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 08:10:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEY1a-00013Y-50 for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 08:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43669) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEY1a-00012x-11 for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 08:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEY1Z-0002nC-Ow for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 08:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2019 12:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs Original-Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.156975895210660 (code B ref 30063); Sun, 29 Sep 2019 12:10:01 +0000 Original-Received: (at 30063) by debbugs.gnu.org; 29 Sep 2019 12:09:12 +0000 Original-Received: from localhost ([127.0.0.1]:52490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEY0l-0002ls-O5 for submit@debbugs.gnu.org; Sun, 29 Sep 2019 08:09:11 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:52952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEY0k-0002ll-LV for 30063@debbugs.gnu.org; Sun, 29 Sep 2019 08:09:11 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEY0h-0000KK-6E; Sun, 29 Sep 2019 14:09:09 +0200 In-Reply-To: <1517054395.9954.0@smtp.gmail.com> ("Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Sat, 27 Jan 2018 12:59:55 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167654 Archived-At: Simen Heggest=C3=B8yl writes: > * lisp/textmodes/rst.el (rst-compile-pdf-preview): Warn about missing > executables when attempting to compile and preview an RST file as PDF. > (Bug#30218) [...] > + (unless (executable-find pdf-compile-program) > + (error "Cannot find executable `%s'" pdf-compile-program)) > + (unless (executable-find rst-pdf-program) > + (error "Cannot find executable `%s'" rst-pdf-program)) Others pointed out that it might be nice to report error messages back from the pdf commands, and that's true, but I think this patch makes sense, too, because it gives good, early feedback on a likely problem, so I think it should be applied. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no