From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 31 Oct 2019 17:06:17 +0100 Message-ID: <87o8xwrjba.fsf@bernoul.li> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="170287"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.1.0; emacs 27.0.50 To: 37774@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 31 17:25:38 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQDGS-000iAS-Qh for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 17:25:36 +0100 Original-Received: from localhost ([::1]:52290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQDGQ-0003V2-SK for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 12:25:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35325) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQCyW-0000Zz-1p for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 12:07:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQCyU-00019S-RF for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 12:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQCyU-00018y-Mj for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 12:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQCyU-0001jC-9o for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 12:07:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Oct 2019 16:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15725379986588 (code B ref 37774); Thu, 31 Oct 2019 16:07:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 31 Oct 2019 16:06:38 +0000 Original-Received: from localhost ([127.0.0.1]:54116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQCy5-0001iC-Mt for submit@debbugs.gnu.org; Thu, 31 Oct 2019 12:06:37 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:45360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQCy1-0001hw-D7 for 37774@debbugs.gnu.org; Thu, 31 Oct 2019 12:06:36 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 96632160E3 for <37774@debbugs.gnu.org>; Thu, 31 Oct 2019 17:06:31 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id Hw3xgYghGkeU for <37774@debbugs.gnu.org>; Thu, 31 Oct 2019 17:06:31 +0100 (CET) Original-Received: from p2 (212-51-149-230.fiber7.init7.net [212.51.149.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 13F9815FA5 for <37774@debbugs.gnu.org>; Thu, 31 Oct 2019 17:06:31 +0100 (CET) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170527 Archived-At: Dmitry keeps urging me to comment here, so I am doing that even though I don't feel like I understand this enough yet to not make a fool of myself. Oh well, if you insist. My main concern--and, due to what I believe to be bugs in the current implementation, I haven't been able to verify whether that is a valid concerns--is that each and every theme that customizes a face that was defined to `extend' beyond eol will have to redo that configuration. If this is really so, then it will take years until all themes have been adjusted and through these years users will keep failing bug reports about broken looks of Magit and other packages. I do not look forward to that. Then again maybe I am wrong about that. However I have glanced over some things that sound like `extend' is getting some special treatment that does not apply to other attributes. If that is so then I would consider that a mistake and a strong indicator that maybe another approach should be found that does not require any special treatment. IMO going with a `noextend' attribute instead of `extend' would be that alternative approach. Even if `extend' does not require any special treatment and even if it does not require each and every theme to be adjusted. Again, I don't know whether there is any special treatment and whether themes have to be adjusted. (It should be clear by now that I am not so happy that Dmitry kept urging me to comment here.) Okay then lets move to the bugs that I have found, possibly. Maybe they are not bugs and I have just done something stupid without realizing it. Anyways... I believe that sometimes a face extends beyond eol even though there is nothing (no explicit `:extend t` nor any `:inherit' what-so-ever) that tells it to do so. Maybe it does make a difference whether the face is used by an overlay or not. Or maybe that is completely irrelevant. Other faces however do not extend past eol and I am unable to see how these faces differ from the faces that do. You can verify that (1) by making sure no theme is in use (2) opening a Magit diff (3) note how most faces extend beyond eol (4) look at the definition of these faces and notice that there is nothing that tells those faces to extend beyond eol. Yet they do. Such faces include for example `magit-section-highlight' and `magit-diff-added'. A counter example is `magit-diff-file-heading-highlight'. That does not extend and I don't see how it is different from the other faces that I mentioned.