From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38365: 26.3; The info doc of eieio-class-name is outdated and its value looks incorrect Date: Tue, 26 Nov 2019 02:34:48 +0100 Message-ID: <87o8wzifnr.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="69629"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38365@debbugs.gnu.org, Stefan Monnier To: Xu Chunyang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 26 02:35:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZPl3-000Hxw-W8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 02:35:14 +0100 Original-Received: from localhost ([::1]:49568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZPl2-0005Gu-Dx for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 20:35:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59802) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZPkt-0005Go-Dt for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 20:35:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZPks-00024O-4z for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 20:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44067) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZPks-00024D-0u for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 20:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZPkr-0003n6-Tm for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 20:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2019 01:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38365 X-GNU-PR-Package: emacs Original-Received: via spool by 38365-submit@debbugs.gnu.org id=B38365.157473210014559 (code B ref 38365); Tue, 26 Nov 2019 01:35:01 +0000 Original-Received: (at 38365) by debbugs.gnu.org; 26 Nov 2019 01:35:00 +0000 Original-Received: from localhost ([127.0.0.1]:50040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZPkp-0003mj-V0 for submit@debbugs.gnu.org; Mon, 25 Nov 2019 20:35:00 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:58146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZPko-0003mR-5r for 38365@debbugs.gnu.org; Mon, 25 Nov 2019 20:34:58 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iZPkf-0008G6-45; Tue, 26 Nov 2019 02:34:51 +0100 In-Reply-To: (Xu Chunyang's message of "Sun, 24 Nov 2019 23:11:10 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172413 Archived-At: Xu Chunyang writes: > (info "(eieio) Predicates") mentions > > -- Function: eieio-class-name class > Return a string of the form =E2=80=98#=E2=80=99 w= hich should > look similar to other Lisp objects like buffers and processes. > Printing a class results only in a symbol. > > but it is not right, the value is not string at all, it's a symbol > > (defclass my-class () ()) > ;; =3D> my-class > > (eieio-class-name 'my-class) > ;; =3D> my-class > > (type-of (eieio-class-name 'my-class)) > ;; =3D> symbol > > The git master produced the same result as Emacs 26.3. I notice Emacs > 24.3's class-name produces the expected result and the function is > replaced by eieio-class-name since 24.4 > > (define-obsolete-function-alias 'class-name #'eieio-class-name "24.4") > > however, these two functions are different. It seems eieio-class-name > contains a bug, the name suggests its value is a string, but it > returns a symbol. My guess is that the documentation in the manual just wasn't updated when this stuff was rewritten back in 2014, and that the return value is correct. Stefan? Currently we have (defun eieio--class-print-name (class) "Return a printed representation of CLASS." (format "#" (eieio-class-name class))) (defun eieio-class-name (class) "Return a Lisp like symbol name for CLASS." (setq class (eieio--class-object class)) (cl-check-type class eieio--class) (eieio--class-name class)) (define-obsolete-function-alias 'class-name #'eieio-class-name "24.4") but eieio--class-print-name is only used as a fallback in one of the prin1 cases. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no