From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Fix for bug #39344 (Gnus selecting deleted buffer) incomplete. Date: Wed, 29 Jan 2020 11:00:47 -0600 Message-ID: <87o8umdwow.fsf@red-bean.com> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="117222"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 29 18:05:30 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iwqmO-000ULc-9r for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Jan 2020 18:05:28 +0100 Original-Received: from localhost ([::1]:49186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwqmN-0003M5-Bp for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Jan 2020 12:05:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49310) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwqi2-0007bJ-Re for emacs-devel@gnu.org; Wed, 29 Jan 2020 12:01:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwqi1-00063L-LK for emacs-devel@gnu.org; Wed, 29 Jan 2020 12:00:58 -0500 Original-Received: from mail-yb1-xb35.google.com ([2607:f8b0:4864:20::b35]:43249) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iwqi1-0005x6-Fy for emacs-devel@gnu.org; Wed, 29 Jan 2020 12:00:57 -0500 Original-Received: by mail-yb1-xb35.google.com with SMTP id k15so158158ybd.10 for ; Wed, 29 Jan 2020 09:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:reply-to:date:message-id:user-agent :mime-version; bh=DgmltsZXG4cy89rqnxP/h4WWYvp2JQd8ip3carWPH9c=; b=CIPNmy914Yy6fRsksAe0/xXSQCnul3gsfsHzk2ByWs+KgB6zY9BK5tiHlAV9W8I74C 4BmxQEznmkmY6g4Mw76aGfBYmayqcyPPakVsYKK7jZKlNHkja75VbBz3WXq08gJtfPju D+oUZdtDOTEIv8ESwo+J77DPHBMLgz1MFIhvrClT6E9Gl8R1K6cEcFPiNxE4Xl+ymgq7 QUFP2NpLSipJkq/bOas7D7Xnjbttnktq9q3RLb7mkCeW55bYaAZfpEF4d2RQHdttaAwX XbalMmzYxKr9GCmtlqWhoaM2hv0u6k1lT0cNX3wE9lgxdBU7AOowkb5lxgsCY0I+RzQj 7zJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:reply-to:date:message-id :user-agent:mime-version; bh=DgmltsZXG4cy89rqnxP/h4WWYvp2JQd8ip3carWPH9c=; b=DRXcaELqJrGBxB6UyMZ5cSyGevsc2L5qXg2L4xJiPzIotgE6Qdrg2Hj/ttLuVOgT/t UqRoYCKKUIcPBAp5DejDbu/g20T+90x0QxB53cEpLbR+eFTwT2jzmJzLM8pQ4K08sdth SjxuzrD/25JX5buJGRW0Edn3mAJfGzDBISMgN6GrPLQ3avaR84G5hfae3PLL5llbR1RN 7YkBOpOTr38ufBfWKJLieh/W78NezHkpzS1rzNQkAqYd9R0huI2N4gyMTi+p18yAQp+L Pxvky+r4XaXFy3CwZR/IFl8mdhMdGuLT3dtksMouEAR4vhGbkT/CebAf6yIJ+c9dGIU/ W+lA== X-Gm-Message-State: APjAAAW92Sy/Nih7Nwwms7vq4MTPt56FLEunZ/o+JRUdG0yHTL/E6Yq+ PLbQ1CzCpNkMQX6iGTLS4q/+X5pG X-Google-Smtp-Source: APXvYqw+MUcE9sirYl4pUu1EWQgPbU1d/VCyyNiTu5wnSwMAxyXT8iMRnhu2fVNW6ZMA4rUE2ZioFQ== X-Received: by 2002:a5b:844:: with SMTP id v4mr360957ybq.170.1580317255374; Wed, 29 Jan 2020 09:00:55 -0800 (PST) Original-Received: from kwork (c-67-173-70-191.hsd1.il.comcast.net. [67.173.70.191]) by smtp.gmail.com with ESMTPSA id w200sm1237230ywa.34.2020.01.29.09.00.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 09:00:54 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::b35 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244751 Archived-At: Hi. I just encountered bug#39344 today (get a "Selecting deleted buffer" error when quitting Gnus). While I was debugging it, coming to the exact same initial workaround that Steve Berman came to in the bug ticket, Sam Steingold committed this intended fix: commit bb3b0990d8505342ae14841144778df9e650ebdc Commit: Sam Steingold CommitDate: Wed Jan 29 11:17:50 2020 -0500 fix bug#39344 * gnus.el (gnus-add-buffer): Use `cl-pushnew' instead of `push' to avoid duplicate entries. I recompiled to get Sam's fix, but the bug is still present. After some debugging, I still don't know why the bug remains, though I've learned a lot about Gnus buffer management, so that's nice. My guess is that this problem is related to earlier commit 5ee3c37634f, in which many functions in Gnus were changed to use `gnus-get-buffer-create' and thus now store the created buffer in in `gnus-buffers'. I did wonder about the fact that `gnus-buffers' is both a variable and a function (with only the latter pruning out the killed buffers) -- that seems like it could a potential confusion source and/or bug source in general, but I don't know if it has anything to do with the current bug. Anyway, before I go deeper, Sam, I thought I'd post this in case your fix is working for you and you didn't realize that it isn't working for someone else. If you can't reproduce the problem anymore after commit bb3b0990d, then I will continue to debug. However, if you can reproduce it, then I'll assume you are working on it (and you surely would do so much more efficiently then I would). Best regards, -Karl