From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Newsgroups: gmane.emacs.bugs Subject: bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error Date: Sun, 12 Apr 2020 12:49:33 +0200 Message-ID: <87o8rxc72a.fsf@gmail.com> References: <20200308090630.41238-1-stepnem@gmail.com> <87pndf17v5.fsf@gnus.org> <87zhcinbdl.fsf@gmail.com> <87d09ezudv.fsf@gnus.org> <83zhciby6s.fsf@gnu.org> <87imioo963.fsf@gmail.com> <875zeinoc0.fsf@gnus.org> <87wo6lc9n8.fsf@gmail.com> <83blnxkn7i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="51521"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, 39980@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 12 12:50:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNaBw-000DJQ-EM for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 12:50:20 +0200 Original-Received: from localhost ([::1]:60582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNaBv-00066Q-4f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 06:50:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46942) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNaBh-00065y-BE for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 06:50:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNaBg-00080J-0V for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 06:50:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45892) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNaBd-0007zY-Ud for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 06:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNaBd-0002bl-T2 for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 06:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Apr 2020 10:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39980-submit@debbugs.gnu.org id=B39980.15866885469955 (code B ref 39980); Sun, 12 Apr 2020 10:50:01 +0000 Original-Received: (at 39980) by debbugs.gnu.org; 12 Apr 2020 10:49:06 +0000 Original-Received: from localhost ([127.0.0.1]:57438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNaAk-0002aV-9a for submit@debbugs.gnu.org; Sun, 12 Apr 2020 06:49:06 -0400 Original-Received: from mail-lj1-f194.google.com ([209.85.208.194]:37166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNaAi-0002ZU-KY for 39980@debbugs.gnu.org; Sun, 12 Apr 2020 06:49:05 -0400 Original-Received: by mail-lj1-f194.google.com with SMTP id r24so6098985ljd.4 for <39980@debbugs.gnu.org>; Sun, 12 Apr 2020 03:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=ESCM9Mw/56R0lb+vwOcq4kvYWvG5KkrYeoXHk5trNkg=; b=YKklwIrU9yryG+wAPyawTMiVodyfCAr6aoW3ZlZEgsIVuFkRmSCFg+gwB/T7YBdWJg GIqrF08eHn+M8462UHprWq19djTvIGBZMrdK3M16I0SeACG5wSzoj5lCNTbkdeqwWuxR keS4UziAEAYr7HtwxwewDHlQUCtGn3+x13rdnwmXaGfm+n0RaMueZRoKz5TVGDPglNk6 jyu0x5KmRktS7lbiw8I1rkOHh+KvVqHDR8k5Si39q19USiJLHe8keptSebKcSyQFK17A o5/wYuKWrCAz5IsBKvKbkDgInMeqBkt+qAohOHK63yeyDJjcSaqHlJqG5lsd81MW1alc c7PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=ESCM9Mw/56R0lb+vwOcq4kvYWvG5KkrYeoXHk5trNkg=; b=H6ll29ziT2bypONm4TcVX/sVs9YkUjw5/aP9Q/LYudIK2tAmVrzhGOzJ8ItSosBuZy E6ENQ2qc4+HGjLqnoDcbmvQmVzTGaN5Bxm93MwUOq0Rfcrpc1zn0KUOCr6/od5+NxURI T3W/UHwpYQJBgymmnwiiYzN06bI5AGGaBoVQkz6EHvCii3K+0mNz6MZAUlG9Q0tQLaDS h1FgKKVNVCmDdqzeU1wypVeyZA1WQSLG8+DAmf+XLbl1Yx5nb31XZseH0b4VCeqeNsTN P23mK5cg1woLSzfFuXeIivSmXTyPGR7noHeZKaVut0WV9HDX/1v2+xN1ubWA9EvuCc+y IFHg== X-Gm-Message-State: AGi0Pua+2jl3W1Kkm/gEAVNR1pk54Z7GD3HsklQLORZQk8J2XKmlbnCz YeOjEz4CE1jOL0kQD8clSvw= X-Google-Smtp-Source: APiQypKfkY4tzG8rhhrv6lGkDDJlOOS1f4/kTDE9zbvt+pOzfF8gxEyHMDLPe6yA+HuK9vtRLrBh4Q== X-Received: by 2002:a05:651c:287:: with SMTP id b7mr7903325ljo.73.1586688538518; Sun, 12 Apr 2020 03:48:58 -0700 (PDT) Original-Received: from localhost ([185.112.167.47]) by smtp.gmail.com with ESMTPSA id k6sm5686450lfm.91.2020.04.12.03.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2020 03:48:57 -0700 (PDT) In-Reply-To: <83blnxkn7i.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Apr 2020 13:33:37 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178233 Archived-At: On Sun, 12 Apr 2020 13:33:37 +0300 Eli Zaretskii wrote: >> From: =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec >> Cc: 39980@debbugs.gnu.org, Lars Ingebrigtsen >> Date: Sun, 12 Apr 2020 11:53:47 +0200 >>=20 >> On Thu, 02 Apr 2020 13:01:35 +0200 >> Lars Ingebrigtsen wrote: >>=20 >> > =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec writes: >> > >> >> Considering the opinions expressed here and in >> >> https://lists.gnu.org/archive/html/emacs-devel/2020-03/msg00541.html I >> >> have reverted to defun and autoload the function instead to prevent >> >> having to load subr-x at runtime whenever gnus-sum is loaded, as it is >> >> currently only used there by `gnus-summary-browse-url'. >> >> >> >> Revised patch attached. >> > >> > Looks good to me. >>=20 >> This can go to emacs-27, right? `gnus-summary-browse-url' is new in >> Emacs 27, it would seem a shame to ship it with this bug. > > OK for the change in gnus-summary-browse-url, but let's please leave > out of emacs-27 changes that aren't necessarily needed to fix the > original problem; cleanups are for master. Understood. > On emacs-27, let's just fix the original problem locally. The revised patch is upthread () There are no changes in the patch that are not necessary for fixing the problem. The ediff changes (only adjusting callers) are necessitated by moving the helper function to subr-x.el, so that Gnus (or anything else) can use it, too. OK? --=20 =C5=A0t=C4=9Bp=C3=A1n