From: "Štěpán Němec" <stepnem@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 39980@debbugs.gnu.org
Subject: bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error
Date: Sun, 12 Apr 2020 12:49:33 +0200 [thread overview]
Message-ID: <87o8rxc72a.fsf@gmail.com> (raw)
In-Reply-To: <83blnxkn7i.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Apr 2020 13:33:37 +0300")
On Sun, 12 Apr 2020 13:33:37 +0300
Eli Zaretskii wrote:
>> From: Štěpán Němec <stepnem@gmail.com>
>> Cc: 39980@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
>> Date: Sun, 12 Apr 2020 11:53:47 +0200
>>
>> On Thu, 02 Apr 2020 13:01:35 +0200
>> Lars Ingebrigtsen wrote:
>>
>> > Štěpán Němec <stepnem@gmail.com> writes:
>> >
>> >> Considering the opinions expressed here and in
>> >> https://lists.gnu.org/archive/html/emacs-devel/2020-03/msg00541.html I
>> >> have reverted to defun and autoload the function instead to prevent
>> >> having to load subr-x at runtime whenever gnus-sum is loaded, as it is
>> >> currently only used there by `gnus-summary-browse-url'.
>> >>
>> >> Revised patch attached.
>> >
>> > Looks good to me.
>>
>> This can go to emacs-27, right? `gnus-summary-browse-url' is new in
>> Emacs 27, it would seem a shame to ship it with this bug.
>
> OK for the change in gnus-summary-browse-url, but let's please leave
> out of emacs-27 changes that aren't necessarily needed to fix the
> original problem; cleanups are for master.
Understood.
> On emacs-27, let's just fix the original problem locally.
The revised patch is upthread
(<https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-03/msg01100.html>)
There are no changes in the patch that are not necessary for fixing the
problem. The ediff changes (only adjusting callers) are necessitated by
moving the helper function to subr-x.el, so that Gnus (or anything else)
can use it, too.
OK?
--
Štěpán
next prev parent reply other threads:[~2020-04-12 10:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 9:06 bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error Štěpán Němec
2020-03-14 11:41 ` Lars Ingebrigtsen
2020-03-14 16:34 ` Štěpán Němec
2020-03-14 18:03 ` Lars Ingebrigtsen
2020-03-14 18:12 ` Štěpán Němec
2020-03-14 18:15 ` Eli Zaretskii
2020-03-28 14:17 ` Štěpán Němec
2020-04-02 11:01 ` Lars Ingebrigtsen
2020-04-12 9:53 ` Štěpán Němec
2020-04-12 10:33 ` Eli Zaretskii
2020-04-12 10:49 ` Štěpán Němec [this message]
2020-04-12 11:05 ` Eli Zaretskii
2020-04-12 11:47 ` Štěpán Němec
2020-04-12 13:38 ` Eli Zaretskii
2020-04-12 14:13 ` Štěpán Němec
2020-04-12 14:35 ` Eli Zaretskii
2020-04-12 20:02 ` Štěpán Němec
2020-04-13 4:26 ` Eli Zaretskii
2020-04-13 10:31 ` Štěpán Němec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8rxc72a.fsf@gmail.com \
--to=stepnem@gmail.com \
--cc=39980@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.