From: Theodor Thornhill <theo@thornhill.no>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 41879@debbugs.gnu.org, "Philip K." <philip@warpmail.net>,
Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el
Date: Tue, 16 Jun 2020 13:29:19 +0000 [thread overview]
Message-ID: <87o8pjkuld.fsf@thornhill.no> (raw)
In-Reply-To: <87mu53i9xf.fsf@tcd.ie>
Hello!
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
[...]
> Nit: For consistency with switch-to-buffer,
> this should be "Switch to buffer: " without the hyphens.
Yes, absolutely!
>> + (lambda (buffer)
>> + (when-let ((file (buffer-file-name (cdr buffer))))
>
> Nit: Neither the manual nor read-buffer's docstring documents what
> (cdr buffer) is here, so a comment mentioning Vbuffer_alist or something
> along those lines would be nice.
It kind of does, though indirectly? But sure, I can add a small comment.
Documentation states that:
"It will be called with each potential candidate, in the form of either a
string or a cons cell whose ‘car’ is a string, and should return non-nil to
accept the candidate for completion, nil otherwise."
[...]
> Otherwise LGTM, thanks,
Nice
next prev parent reply other threads:[~2020-06-16 13:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 17:45 bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Theodor Thornhill
2020-06-15 18:29 ` Philip K.
2020-06-15 20:55 ` Dmitry Gutov
2020-06-15 22:05 ` Theodor Thornhill
2020-06-15 23:38 ` Dmitry Gutov
2020-06-16 5:45 ` Theodor Thornhill
2020-06-16 6:11 ` Philip K.
2020-06-16 6:49 ` Theodor Thornhill
2020-06-16 10:26 ` Basil L. Contovounesios
2020-06-16 13:29 ` Theodor Thornhill [this message]
2020-06-16 14:02 ` Basil L. Contovounesios
2020-06-16 16:53 ` Theodor Thornhill
2020-06-16 18:19 ` Basil L. Contovounesios
2020-06-16 18:58 ` Theodor Thornhill
2020-06-16 20:37 ` Basil L. Contovounesios
2020-06-16 22:39 ` Dmitry Gutov
2020-06-17 23:10 ` Dmitry Gutov
2020-06-16 21:40 ` Dmitry Gutov
2020-06-16 21:58 ` Basil L. Contovounesios
2020-06-16 22:11 ` Dmitry Gutov
2020-06-15 23:10 ` Juri Linkov
2020-06-16 0:21 ` Dmitry Gutov
2020-06-18 9:41 ` Andrii Kolomoiets
2020-06-18 10:11 ` Theodor Thornhill
2020-06-18 10:26 ` Theodor Thornhill
2020-06-18 10:31 ` Theodor Thornhill
2020-06-18 10:48 ` Andrii Kolomoiets
2020-06-18 11:07 ` Dmitry Gutov
2020-06-18 11:30 ` Andrii Kolomoiets
2020-06-18 11:35 ` Dmitry Gutov
2020-06-18 11:47 ` Andrii Kolomoiets
2020-06-18 13:00 ` Dmitry Gutov
2020-06-18 18:03 ` Andrii Kolomoiets
2020-06-18 18:49 ` Theodor Thornhill
2020-06-18 19:35 ` Basil L. Contovounesios
2020-06-19 0:43 ` Dmitry Gutov
2020-06-19 4:50 ` Andrii Kolomoiets
2020-06-19 0:45 ` Dmitry Gutov
2020-06-19 4:59 ` Andrii Kolomoiets
2020-06-19 5:27 ` Theodor Thornhill
2020-06-19 11:00 ` Dmitry Gutov
2020-06-20 8:35 ` Andrii Kolomoiets
2020-06-21 1:04 ` Dmitry Gutov
2020-06-22 9:30 ` Andrii Kolomoiets
2020-06-22 13:46 ` Dmitry Gutov
2020-06-22 13:54 ` Andrii Kolomoiets
2020-06-22 14:59 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8pjkuld.fsf@thornhill.no \
--to=theo@thornhill.no \
--cc=41879@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=dgutov@yandex.ru \
--cc=philip@warpmail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.