From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode Date: Sun, 09 Aug 2020 21:18:18 +0200 Message-ID: <87o8njbpc5.fsf@gnus.org> References: <875znjntfe.fsf@mail.linkov.net> <83mugvhr66.fsf@gnu.org> <871ry6rksu.fsf@mail.linkov.net> <83zhksexvx.fsf@gnu.org> <87sgqhricg.fsf@mail.linkov.net> <87o914u65x.fsf@mail.linkov.net> <04C790C7-2667-4480-BDC9-BE838D307A74@aol.com> <837e7qcpbj.fsf@gnu.org> <20190806175146.fpgzslvlaydpih7k@Ergus> <831rxycfqp.fsf@gnu.org> <2F586079-3687-4DF0-984D-467F442E68D1@aol.com> <83sgqdavg9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16692"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Ergus , 36861@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 09 21:19:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4qqd-0004Bm-Om for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Aug 2020 21:19:11 +0200 Original-Received: from localhost ([::1]:36132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4qqc-0001EI-5S for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Aug 2020 15:19:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4qqU-0001Dp-Iz for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 15:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50157) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4qqU-0000Q0-AD for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 15:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4qqU-0003Nn-5N for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 15:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36861-submit@debbugs.gnu.org id=B36861.159700071212949 (code B ref 36861); Sun, 09 Aug 2020 19:19:02 +0000 Original-Received: (at 36861) by debbugs.gnu.org; 9 Aug 2020 19:18:32 +0000 Original-Received: from localhost ([127.0.0.1]:33467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4qq0-0003Mn-De for submit@debbugs.gnu.org; Sun, 09 Aug 2020 15:18:32 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4qpx-0003MP-NC for 36861@debbugs.gnu.org; Sun, 09 Aug 2020 15:18:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yIKas1XntM2wqXc6wlNu4aHsE3akI/CX1iyONIDDqDg=; b=p30K+/q8DzDiSSQwBsNNH4WL8R F3B5XIvvJNDDUrciIPZ1MoNUB6d9OSd0saeoQXNIHJ7tJptNTKj1q6WYQWNJ6EfSAF2v13htohKQ8 X+4Y7QH9ZwLlKkT2ZsF43yDfTFSvEKCpmIqrK81eFaBqOWUv9bRpk9CpW8jbDWHrqEQY=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4qpo-0002g0-EH; Sun, 09 Aug 2020 21:18:23 +0200 In-Reply-To: <83sgqdavg9.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 07 Aug 2019 17:42:14 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184445 Archived-At: Eli Zaretskii writes: >> There is also the case when a user sets ?| by default and then call >> the function. If the check we add is just >> comparing to the default value then ?| will be always overwritten so >> an extra internal variable will be needed to >> cache where the ?| comes from. > > Not sure we need another variable. After all, if the conditions > stayed the same, the result will be the same as well, and you will > overwrite the value with an identical one. Right? Reading the code, if display-fill-column-indicator-character is set, then the mode will never do its computation to see whether we can use the prettier U+2502 =E2=94=82 character. We could special-case that, thoug= h, and if it's ?|, then we replace it with ?=E2=94=82 (that is, ascii bar with Unicode bar). That would be kinda hacky, though, wouldn't it? Then there would no way to use the ASCII bar, for those that hate all things Unicode. So we'd need another variable, unfortunately. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no