all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 9d0385d: Fix problem with 8bit content-transfer-encoding in nndoc mbox files
Date: Sat, 22 Aug 2020 15:43:42 +0200	[thread overview]
Message-ID: <87o8n2n6cx.fsf@gnus.org> (raw)
In-Reply-To: <83364fbx31.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Aug 2020 22:47:14 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> I think you want to swap the order: first erase-buffer, and then
> set-buffer-multibyte.  That's because the latter in a non-empty buffer
> can be expensive, and tis actually waste of cycles if you are going to
> erase the buffer.

Yup, I've now done this.  Looking at the code, it looks like a possibly
offensive case of defensive programming -- that buffer will be empty
when the `erase-buffer' is called, I think.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



      parent reply	other threads:[~2020-08-22 13:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21 19:47 master 9d0385d: Fix problem with 8bit content-transfer-encoding in nndoc mbox files Eli Zaretskii
2020-08-21 20:07 ` Stefan Monnier
2020-08-22 13:43 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8n2n6cx.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.