From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources Date: Sun, 23 Aug 2020 23:27:03 +0200 Message-ID: <87o8n1aw9k.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10384"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 43004@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 23 23:28:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9xXS-0002a8-IC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Aug 2020 23:28:30 +0200 Original-Received: from localhost ([::1]:44886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9xXR-0005JB-Ey for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Aug 2020 17:28:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9xX0-0005IS-9u for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43697) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k9xX0-0008Fw-1M for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k9xWz-0001q0-VB for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Aug 2020 21:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43004 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15982180307003 (code B ref -1); Sun, 23 Aug 2020 21:28:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Aug 2020 21:27:10 +0000 Original-Received: from localhost ([127.0.0.1]:55243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9xWA-0001ot-6m for submit@debbugs.gnu.org; Sun, 23 Aug 2020 17:27:10 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9xW8-0001ol-BE for submit@debbugs.gnu.org; Sun, 23 Aug 2020 17:27:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9xW8-0004kd-5N for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:27:08 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:40683) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9xW6-0008Ab-1n for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:27:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598218024; bh=9zrhIyeRec70tABMq30PBFJuMGvqVYz/+lDzAP/Wgaw=; h=X-UI-Sender-Class:From:To:Subject:Date; b=MKKwZZUtcFkP+RwXPhl1+15cfY7g3k/WKLFe0ppxyvNa7IVhRDFcFZWn3Z8bxAg8/ pCRNIP9/fZV7gzfVV8y4U3+bmGCDqaq8LGtP/TZiVhU6PiJgdTR6MGwkxufWE34BzX GFulm54IttUEK8jqWfBufGy2ZF8GqmKKhs0h1i9o= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-jhalfs ([92.73.78.116]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mn2WF-1ksfeh0mSV-00k47s for ; Sun, 23 Aug 2020 23:27:04 +0200 X-Provags-ID: V03:K1:RpiLGj8Hi9tcWown+M74tja1S6JQOgiFSsB+rNjO2mNdFXr8/f9 iBnEBIge3KyH2mQnYmnB2L4rs9JGA5SOzRpxhiI4JV8SqZaiv80eKejfh0Qp8ovqLCefc43 cMil+p17gQWdTIonrQ5nnZmO2aTZ0iyy2IoRx0e8QK+SuRIReTFspaSiJSjiC9MwkesiGYL LAOkpBHbiMDk/dHwCEfeg== X-UI-Out-Filterresults: notjunk:1;V03:K0:l6lpWtpptIU=:o7mRlbirjaMn73m9Qc7yRw gXC/C50aRS/h5MR5e/rgOZ9ZryVAM9/oAel+MDONDuy/5NnezMqut6XmpODJlhFlYm7J4uD3x bAuPWIlDU0npGBJbT60R/swp3n2bqL3kybys57p5vfYQtcENC8V93Dn5mnSn/mtmsei37X4xx kQw9pQlo0cEwwxLl8Snpx487gX1wo/M8ZekGZBvw//9mwlKKs7YtNqJlfmbiTdZEK+ggUe9fj VXFmG3yi70JXuRF2H87LZABNXLpXLvRGwAy9j6X5PzoBtnA4aqiyGF5rsDmlNCPyWQNhrGjcR WLkauQNAImKuDBfWRT8EQJBj2aL5C1ickxsSg9CTbVBkWbG0Bn7q5llwXI6sq2/IoYZwNxTyy LI88gEucNtrnhgLDxXrupR8fX59DRQS9pI37kjCZH0jChdE8pK+P+JT/5JBJhNXLlwwrJqNVR xGXj4H7/q5KHFq8AnwpDl55xtaEVXzSjgZGY/y1aje7X2esFdTnfKsS9Ydmx/iQpBAwJkbrS0 z1v9rQFnXnKGroC8Ni2+aqq/t/1D3UaEGCp96mpCyvQDdx8jlbj0iYmn8AxU3JVQmWV5FoT3M JmLJu/ZwbOhChn4jBx28gU+qnqxklq4DG6fxovkB8+wQLPPiuZZrSvTAWboaCvULqx+ajrsKD 93B9Kkna8dScb3Y7cilA6Q56vFqElj2PBtsL2EBpf2Mip0YnLiB41LX8K7AEpv/4sMmWweQ27 NfXYSbAryJytq19+SEhtcjUiN6M4HMebOYBGFkTpfPJ09aBtjjaZJJ8b0jOTS6R3dq4gfjLX Received-SPF: pass client-ip=212.227.17.20; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/23 17:27:04 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186091 Archived-At: After my latest build from master I ran make check (for the first time in a long time) and got the following 20 unexpected failures: In test/lisp/progmodes/elisp-mode-tests.el 14 unexpected results: FAILED xref-elisp-test-find-defs-defgeneric-co-located-default FAILED xref-elisp-test-find-defs-defgeneric-el FAILED xref-elisp-test-find-defs-defgeneric-implicit-generic FAILED xref-elisp-test-find-defs-defgeneric-no-default FAILED xref-elisp-test-find-defs-defgeneric-no-methods FAILED xref-elisp-test-find-defs-defgeneric-separate-default FAILED xref-elisp-test-find-defs-define-overload-co-located-default FAILED xref-elisp-test-find-defs-define-overload-no-default FAILED xref-elisp-test-find-defs-define-overload-no-methods FAILED xref-elisp-test-find-defs-define-overload-separate-default FAILED xref-elisp-test-find-defs-defun-defvar-el FAILED xref-elisp-test-find-defs-defun-el FAILED xref-elisp-test-find-defs-defvar-el FAILED xref-elisp-test-find-defs-feature-el In test/lisp/help-fns-tests.el 5 unexpected results: FAILED help-fns-test-alias-to-defun FAILED help-fns-test-bug23887 FAILED help-fns-test-lisp-defsubst FAILED help-fns-test-lisp-defun FAILED help-fns-test-lisp-macro In test/lisp/emacs-lisp/cl-generic-tests.el 1 unexpected result: FAILED cl-generic-tests--method-files--finds-methods It seems that the failures arise because my Emacs sources are in a directory on a different partition from my home directory, and the source directory is symlinked from =C2=A7HOME, and my Emacs build directory is under $HOME. When I do batch runs of the test three files in question starting from my home directory (i.e. dereferencing the symlink to the sources), I get the the failures I reported; but when I start the batch runs from the real directory containing the test sources, the one test in cl-generic-tests.el that failed now passes, and of the fourteen xref tests in elisp-mode-tests.el that failed, now only these five fail: FAILED xref-elisp-test-find-defs-defgeneric-el FAILED xref-elisp-test-find-defs-defun-defvar-el FAILED xref-elisp-test-find-defs-defun-el FAILED xref-elisp-test-find-defs-defvar-el FAILED xref-elisp-test-find-defs-feature-el But all five of the failing tests in help-fns-tests.el still fail. However, concerning the latter, it seems that the tests expect help-fns-function-description-header to return the quoted basename of the file, while in my environment it returns the absolute filename. Adjusting the regexp used in the tests fixes this issue (see the first patch below) and then all tests pass regardless of where I start the batch run. Concerning cl-generic-tests.el, using file-truename as in the second patch below prevents the one failure, also regardless of where I start the batch run. As for the failing xref tests in elisp-mode-tests.el, by applying file-truename to the result of calls to find-lisp-object-file-name in elisp--xref-find-definitions (in elisp-mode.el) and xref-mode-local-overload (in mode-local.el) I could reduce the 14 failures to the same five that fail when doing the batch run from the real directory without following the symlink. The same reduction but not full elimination is achieved by removing the call to file-truename in the value of the defvar emacs-test-dir in elisp-mode-tests.el. So far I haven't figured out how to prevent these five failures. diff --git a/test/lisp/help-fns-tests.el b/test/lisp/help-fns-tests.el index da2b49e6b8..7782a41b9f 100644 --- a/test/lisp/help-fns-tests.el +++ b/test/lisp/help-fns-tests.el @@ -56,28 +56,28 @@ help-fns-test-interactive-built-in (should (string-match regexp result)))) =20 (ert-deftest help-fns-test-lisp-macro () - (let ((regexp "a Lisp macro in .subr\\.el") + (let ((regexp "a Lisp macro in .+subr\\.el") (result (help-fns-tests--describe-function 'when))) (should (string-match regexp result)))) =20 (ert-deftest help-fns-test-lisp-defun () - (let ((regexp "a compiled Lisp function in .subr\\.el") + (let ((regexp "a compiled Lisp function in .+subr\\.el") (result (help-fns-tests--describe-function 'last))) (should (string-match regexp result)))) =20 (ert-deftest help-fns-test-lisp-defsubst () - (let ((regexp "a compiled Lisp function in .subr\\.el") + (let ((regexp "a compiled Lisp function in .+subr\\.el") (result (help-fns-tests--describe-function 'posn-window))) (should (string-match regexp result)))) =20 (ert-deftest help-fns-test-alias-to-defun () - (let ((regexp "an alias for .set-file-modes. in .subr\\.el") + (let ((regexp "an alias for .set-file-modes. in .+subr\\.el") (result (help-fns-tests--describe-function 'chmod))) (should (string-match regexp result)))) =20 (ert-deftest help-fns-test-bug23887 () "Test for https://debbugs.gnu.org/23887 ." - (let ((regexp "an alias for .re-search-forward. in .subr\\.el") + (let ((regexp "an alias for .re-search-forward. in .+subr\\.el") (result (help-fns-tests--describe-function 'search-forward-regexp)= )) (should (string-match regexp result)))) =20 diff --git a/test/lisp/emacs-lisp/cl-generic-tests.el b/test/lisp/emacs-lis= p/cl-generic-tests.el index 5aa58782f3..9582907e51 100644 --- a/test/lisp/emacs-lisp/cl-generic-tests.el +++ b/test/lisp/emacs-lisp/cl-generic-tests.el @@ -240,7 +240,7 @@ cl-generic-tests--method-files--finds-methods (let ((retval (cl--generic-method-files 'cl-generic-tests--generic))) (should (equal (length retval) 2)) (mapc (lambda (x) - (should (equal (car x) cl-generic-tests--this-file)) + (should (equal (file-truename (car x)) cl-generic-tests--this-= file)) (should (equal (cadr x) 'cl-generic-tests--generic))) retval) (should-not (equal (nth 0 retval) (nth 1 retval))))) In GNU Emacs 28.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version 3.24.17, = cairo version 1.17.3) of 2020-08-21 built on strobe-jhalfs Repository revision: 3e10174fb65f4eb601b1921271bdcf10c933b879 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Linux From Scratch SVN-20200401 Configured using: 'configure 'CFLAGS=3D-Og -g3' PKG_CONFIG_PATH=3D/opt/qt5/lib/pkgconfig' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD PDUMPER LCMS2