From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Caio Henrique Newsgroups: gmane.emacs.bugs Subject: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo Date: Thu, 10 Sep 2020 15:29:11 -0300 Message-ID: <87o8mdzds8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25207"; mail-complaints-to="usenet@ciao.gmane.io" To: 43315@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 10 20:58:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGRm4-0006SC-DF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 20:58:24 +0200 Original-Received: from localhost ([::1]:38144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGRm3-0002kw-EW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 14:58:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGRKc-0002ez-Nn for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGRKc-000456-DB for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGRKc-0004gB-8E for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Caio Henrique Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Sep 2020 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43315 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.159976256317905 (code B ref -1); Thu, 10 Sep 2020 18:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Sep 2020 18:29:23 +0000 Original-Received: from localhost ([127.0.0.1]:41161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRJy-0004ej-Qg for submit@debbugs.gnu.org; Thu, 10 Sep 2020 14:29:23 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:50516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRJx-0004ec-L8 for submit@debbugs.gnu.org; Thu, 10 Sep 2020 14:29:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGRJx-00019P-Ca for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:29:21 -0400 Original-Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]:37279) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGRJv-000428-Kq for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:29:21 -0400 Original-Received: by mail-qt1-x842.google.com with SMTP id k25so5671517qtu.4 for ; Thu, 10 Sep 2020 11:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=5wwTokQNIe9vDxyMkxGA5YO00HP5EXuvfh0J0atTqKA=; b=Ry500V+2xeeih+x949gmox+DOsZ1fasszTKnxCX1c2tGIg6Iq3KJxqrQEFIPsAyOvP cm8fR4XqrFWEgMN/VCf0+kW1XInLIihi2B5M1b8V7YFqrulRZ2PqzdHdoy4zowjCvDLI gb8tEjYQtNSVSgQ/SOFpCMrAWFDHokDFzo7WjxKM4vCaq55nU9iOiQk2w1OMRrx22ApO 2+ckvuLcysYBerSFuM0l8hQDKtVLV+ON18cGz/YTRJDSy6tY2o+4AYcHT/crxfTDcBRw u4ijRSGg51RjYNRqGhtSTAA+/1fyNMzeIdq24oW8CBQG5nypKqpqxrmohfQyz9iSG6ew V2Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=5wwTokQNIe9vDxyMkxGA5YO00HP5EXuvfh0J0atTqKA=; b=Cz7ziUNPt2QaFoq0i9kpfdGZnkz8L1exhe55kgjeHu8OuvsjYdlqZBSIc8xuoCC5H6 X5WAt/lgBEJMk4b3rFohomIEj7n+p0hhZiUjXPr7n03MQ5P5wka8UbZ/n0OSxviuXcMq A6soyWt2gKg+FQB+l9+C4/bPz+9DvKuha3XNQzwFo1WN6bUxuznbGSMA1fEFx1GEbzJ/ 6ERyNsmY8ylsR+IPwKTB6zlWkjkYJJh+CRQOagzyhXwNnjGSP1iMk1eBL79UPO/l53A9 pbO/uIU3U5tY9qAuyTfC4StqQoFs6d5FifsOEtoIRlEoltIgi9AMTaWX0+v33L3Qx3KI 3a6Q== X-Gm-Message-State: AOAM5312/Rxdc5enG0PgzAb0dvOk3Mse5Fwzv+eaSana+mBWS0bEUElJ QLnxsuyYu/cXqcZxV6toFoFEcPwdi/E= X-Google-Smtp-Source: ABdhPJxWqXLMWPnKyYgnnpEodTtqX1su5XHzFrDIatun4uiT3/m3OKwoKEkf51/1KIWQrSK4e/iAeA== X-Received: by 2002:ac8:5d43:: with SMTP id g3mr9518270qtx.295.1599762557916; Thu, 10 Sep 2020 11:29:17 -0700 (PDT) Original-Received: from localhost.localdomain ([181.223.151.236]) by smtp.gmail.com with ESMTPSA id u66sm7738278qka.136.2020.09.10.11.29.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 11:29:17 -0700 (PDT) X-Google-Original-From: Caio Henrique Received-SPF: pass client-ip=2607:f8b0:4864:20::842; envelope-from=caiohcs0@gmail.com; helo=mail-qt1-x842.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187754 Archived-At: Hi, After the recent discussions to improve discoverability of Emacs, I analyzed the Emacs menu-bar and the menu bar of other text editors. They all have a "Redo" option close to the "Undo". Here are some examples: 1. nano When you launch nano on the terminal, you can see the text on the bottom that says "M-E Redo", right bellow "Undo". 2. libreoffice write When you open the Edit menu, you will find that the first option is "Undo" and the second is "Redo". 3. Notepad++ Same as libreoffice write. 4. Visual Studio Code Same as libreoffice write. Here is my proposal: I'm not used to the default undo system since I use undo-tree, but it seems that Emacs 28 has added a function called undo-redo to the simple.el file, right? My proposal is to add it to the menu-bar, right bellow "Undo": _____ diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index bc094c9050..30d86c7f17 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -536,6 +536,12 @@ menu-bar-edit-menu (if (featurep 'ns) (bindings--define-key menu [separator-undo] menu-bar-separator)) + (bindings--define-key menu [undo-redo] + '(menu-item "Redo" undo-redo + :enable (and (not buffer-read-only) + (undo--last-change-was-undo-p buffer-undo-list)) + :help "Undo last undo")) + (bindings--define-key menu [undo] '(menu-item "Undo" undo :enable (and (not buffer-read-only) ____ Cordially, Caio Henrique