From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ulf Jasper Newsgroups: gmane.emacs.bugs Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling Date: Thu, 01 Oct 2020 21:14:43 +0200 Message-ID: <87o8llu5b0.fsf@panama> References: <23640.9851.562972.730234@AGAME7.local> <87zh7267sy.fsf@gnus.org> <87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@gnu.org> <24369.32256.954408.774614@AGAME7.local> <87y2mlxx8r.fsf@gnus.org> <87d03x43kz.fsf@panama> <24371.59842.984273.402129@AGAME7.local> <87y2mkknyc.fsf@gnus.org> <24371.61149.995030.284670@AGAME7.local> <87364rq4yl.fsf@panama> <87imcwf404.fsf@panama> <24400.43911.666145.400179@AGAME7.local> <874kof2aui.fsf@panama> <24435.1743.473339.944597@AGAME7.local> <874knewwfc.fsf@gnus.org> <24437.56299.111042.412318@AGAME7.local> <87d021vrzi.fsf@panama> <877ds9rk4j.fsf@gnus.org> <878scpvqcf.fsf@panama> <24438.9378.994810.275603@AGAME7.local> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28454"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: Lars Ingebrigtsen , 34315@debbugs.gnu.org, Jan Tatarik To: thunk2@arcor.de (Thomas Plass) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 21:15:58 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO43a-0007In-Oj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 21:15:58 +0200 Original-Received: from localhost ([::1]:57874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO43Z-0002Dx-5o for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 15:15:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO42g-0002Dj-VP for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 15:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55064) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO42g-0001I2-Ld for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 15:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kO42g-0002dq-IQ for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 15:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ulf Jasper Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 19:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34315-submit@debbugs.gnu.org id=B34315.160157969410128 (code B ref 34315); Thu, 01 Oct 2020 19:15:02 +0000 Original-Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 19:14:54 +0000 Original-Received: from localhost ([127.0.0.1]:38377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO42X-0002dI-MO for submit@debbugs.gnu.org; Thu, 01 Oct 2020 15:14:53 -0400 Original-Received: from mout.web.de ([212.227.17.12]:34571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO42W-0002cw-Bi for 34315@debbugs.gnu.org; Thu, 01 Oct 2020 15:14:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1601579684; bh=3SdXiQcaMgDWfwgY2dp9BwMvk2jzQ7uqTp6HJM79uIk=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=KbeHlt3uENtvMUWqSRUUCtpZ6iNfH6VFQXLS4R0JhDr1BpwWcC6gUtc3lE934bAKY ZF+nIVJ88fchkDduhBSd0AniIZlT7RK7kafWD+u33y5+ze8aG6m/hbXcKixz4oQoFD hvd3kSs0hY+a3wHAjkqNOp7NYtXxgANFlq6776sQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from udesktop ([87.187.48.89]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LlWKh-1kw1kB38dD-00bIwG; Thu, 01 Oct 2020 21:14:44 +0200 In-Reply-To: <24438.9378.994810.275603@AGAME7.local> (Thomas Plass's message of "Thu, 1 Oct 2020 21:49:06 +0300") X-Provags-ID: V03:K1:Cxt1gbDqfDr/GgXqLOI/cYnJPpNo5YxsOqVjP6W8vbExHKO77aR 3dpLdHlUWi0SPE/3NH0A9EZDfybIrux9Pp3lFIeiAnXFh0THGrQqMSbnJlTbBi2LK+Cv3eg gwP1XyZhBW1KEDl+YKUl+bM52LBQr1KMfqwD4pLeqVg+EwS+e9klCYj2BGnzPwo6PL1XOah HcLA5XaLPHt73H1h8wjwA== X-UI-Out-Filterresults: notjunk:1;V03:K0:zc3x4ETfn1k=:V5lIFsLprEeuDBrEnNdBZj K+dqFcc4B2jAsmaMdL8qIa3fDKzwKL7O/rW8GOlEBob38N7UWhp8H6PfMZxDtlWY0Z8K4gSeT ZsIw+vpfRN1kv0C0qxLIPEsAh8mYfu36Lngvm0/EMr6n/8kJqHLn7JLw2XA9Lm/r7Xp7Ytxd7 +YKuHQt+lksLo5jq0rKKVajaay7JwWLqkfCLINETmnCXlwQsBezFD9oK2SZ55z1BPOgou9Xti ZN7/cEstjy0BInkYlxcrt8JqcNrshhc0mL5b2VzWve0/AfvkpKO2OClOIE5lJY0knctbfaYiI antyOg6D5LFwNAZmOA5JA+Vzrp4pBIUXf2n/IhrLTn6YxDpKJOxMcu207iccQebnaJNb7OkK5 iQUYzc6wn1EA4Gtb5O5YodmgptxA9RVYTqm8xqddkRbAvLwRnxwKT85hmzefg2CXNdBGlylcZ VGV0zjUwlQ42eVOGG2jl8N3FAs777r89Kp8Jy1X4mTFzdsycORejCPHpVOikBcz/2fC+OvtXw JWJ6BsHmB3gPQO0UH5jvzCJsio8BqvcDdXsm1TBF8eghi7M/bT2QCr9n1wC5K1qmfklZecGVw /mMyZP7qU29tcREP6pFhR3d1KouMtOrOa1f2QZf2A7dh80X6Frw+HvVehlWs+bdmx+8ar13/L pCIA7zkE6xvy0P9gr77prqpOtN38BpW2/xgOCZAm3tXKITV2Qjx6BPREXEReEAqX2MelRoAJq jtXyn6tDuTCF7i2TkJ9bsN+Y9Qph2xXdF/Ei6bJHSU5tGgYEke+5PHbtcM/A0sTOH3R/5f8O X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189567 Archived-At: Am 01.10.2020 um 21:49 (+0300) schrieb Thomas Plass: > I'd like to get some guidance from people involved on the following > proposal: That is close to what I have in mind. When we out-source test input data, we should do the same with the corresponding expected results. A unit test case would look something like this. - read input data from ics file - read expected result from corresponding file - perform action under test on input data - compare result with previously read expected result I could write the necessary helper functions and then, for a start, apply this scheme to the "real world" tests in icalendar-tests.el.