* Re: [elpa] master 9ef4325: * debbugs-gnu.el (debbugs-gnu--parse-mail): Pacify byte compiler.
[not found] ` <20201011083737.0D1FC20667@vcs0.savannah.gnu.org>
@ 2020-10-11 13:27 ` Stefan Monnier
2020-10-11 13:42 ` Michael Albinus
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2020-10-11 13:27 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
> diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el
> index 5084b61..ceddc00 100644
> --- a/packages/debbugs/debbugs-gnu.el
> +++ b/packages/debbugs/debbugs-gnu.el
> @@ -2680,6 +2680,9 @@ If SELECTIVELY, query the user before applying the patch."
> (defun debbugs-gnu--parse-mail (string)
> (let* ((mail-extr-ignore-single-names nil)
> (mail-extr-ignore-realname-equals-mailbox-name nil))
> + ;; Pacify byte compiler.
> + (ignore
> + mail-extr-ignore-single-names mail-extr-ignore-realname-equals-mailbox-name)
> (mail-extract-address-components string)))
>
I suspect this is wrong because the warnings here reflects a real bug.
The bug is that those variables should not be bound lexically but
dynamically, so the real fix is to add
(defvar mail-extr-ignore-single-names)
(defvar mail-extr-ignore-realname-equals-mailbox-name)
somewhere earlier, or to `require` the package which defines those two vars.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-11 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201011083736.5056.91918@vcs0.savannah.gnu.org>
[not found] ` <20201011083737.0D1FC20667@vcs0.savannah.gnu.org>
2020-10-11 13:27 ` [elpa] master 9ef4325: * debbugs-gnu.el (debbugs-gnu--parse-mail): Pacify byte compiler Stefan Monnier
2020-10-11 13:42 ` Michael Albinus
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.